[GitHub] spark pull request: [SPARK-2140] Enabling YARN memory overhead cal...

[witgo <gi...@git.apache.org>]

Github user witgo commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1906#discussion_r16121764
  
    --- Diff: yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -113,11 +113,12 @@ class Client(clientArgs: ClientArguments, hadoopConf: Configuration, spConf: Spa
       }
     
       def calculateAMMemory(newApp: GetNewApplicationResponse) :Int = {
    +    // It looks like -Xmx is handled in ClientBase. ?
         // TODO: Need a replacement for the following code to fix -Xmx?
    -    // val minResMemory: Int = newApp.getMinimumResourceCapability().getMemory()
    -    // var amMemory = ((args.amMemory / minResMemory) * minResMemory) +
    -    //  ((if ((args.amMemory % minResMemory) == 0) 0 else minResMemory) -
    -    //    memoryOverhead )
    +    val minResMemory: Int = newApp.getMinimumResourceCapability().getMemory()
    +    var amMemory = ((args.amMemory / minResMemory) * minResMemory) +
    +     ((if ((args.amMemory % minResMemory) == 0) 0 else minResMemory) -
    +       memoryOverhead )
         args.amMemory
    --- End diff --
    
    There is always returns `args.amMemory`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org