You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by kisimple <gi...@git.apache.org> on 2017/05/17 13:02:52 UTC

[GitHub] spark pull request #18018: [SPARK-12686][SQL] Support aggregation push down ...

GitHub user kisimple opened a pull request:

    https://github.com/apache/spark/pull/18018

    [SPARK-12686][SQL] Support aggregation push down into data sources

    This pr enable Sum/Count/Average/Max/Min partial aggregation push down into data sources for logical plan nodes like `Aggregate -> Project -> (Filter) -> Scan`. 
    The data sources need to implement the new added trait `AggregatedFilteredScan` and set `spark.sql.aggregation.pushdown` to true.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kisimple/spark SPARK-12686

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18018.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18018
    
----
commit 8b207250cde7baa3a290cca962fd518802af26e4
Author: blueszheng <bl...@tencent.com>
Date:   2017-05-17T07:21:25Z

    [SPARK-12686][SQL] Support aggregation push down into data sources

commit a7121f96b36a5d1b112e136f5fa802a8ba601d3a
Author: blueszheng <bl...@tencent.com>
Date:   2017-05-17T07:21:25Z

    [SPARK-12686][SQL] Support aggregation push down into data sources

commit 90fd2467c8d801a1f4c951eed93c766a6809fae9
Author: blueszheng <bl...@tencent.com>
Date:   2017-05-17T12:52:08Z

    Merge branch 'SPARK-12686' of https://github.com/kisimple/spark into SPARK-12686

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18018: [SPARK-12686][SQL] Support aggregation push down into da...

Posted by kisimple <gi...@git.apache.org>.
Github user kisimple commented on the issue:

    https://github.com/apache/spark/pull/18018
  
    @rxin any suggestions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18018: [SPARK-12686][SQL] Support aggregation push down into da...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/18018
  
    @kisimple We are working on the Data Source API v2. Could you close this PR? Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #18018: [SPARK-12686][SQL] Support aggregation push down ...

Posted by kisimple <gi...@git.apache.org>.
Github user kisimple closed the pull request at:

    https://github.com/apache/spark/pull/18018


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18018: [SPARK-12686][SQL] Support aggregation push down into da...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18018
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org