You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Boris Shkolnik (JIRA)" <ji...@apache.org> on 2009/11/23 19:19:39 UTC
[jira] Created: (MAPREDUCE-1236) added LOG.isdebugenabled for
LOG.debug() as noted in MAPREDUCE-1026
added LOG.isdebugenabled for LOG.debug() as noted in MAPREDUCE-1026
-------------------------------------------------------------------
Key: MAPREDUCE-1236
URL: https://issues.apache.org/jira/browse/MAPREDUCE-1236
Project: Hadoop Map/Reduce
Issue Type: Improvement
Reporter: Boris Shkolnik
Priority: Minor
in /MAPREDUCE-1026 we introduces few LOG.debug() not constrained by LOG.isdebugenabed() .
Fixing that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1236) added LOG.isdebugenabled for
LOG.debug() as noted in MAPREDUCE-1026
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated MAPREDUCE-1236:
--------------------------------------
Attachment: MAPREDUCE-1236.patch
> added LOG.isdebugenabled for LOG.debug() as noted in MAPREDUCE-1026
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-1236
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1236
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Priority: Minor
> Attachments: MAPREDUCE-1236.patch
>
>
> in /MAPREDUCE-1026 we introduces few LOG.debug() not constrained by LOG.isdebugenabed() .
> Fixing that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1236) added LOG.isdebugenabled for
LOG.debug() as noted in MAPREDUCE-1026
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781520#action_12781520 ]
Konstantin Boudnik commented on MAPREDUCE-1236:
-----------------------------------------------
While {{LOG.isDebugEnabled()}} will allow not to construct a possible complex and thus costly message object it isn't necessary a good idea in general to use this check everywhere. Say, if a debug message is a simple string literal then it will be created at the compile time. Effectively, you'll end up with _two_ checks of the configured log level in such a case.
Just a reminder not to use it blindly :-)
> added LOG.isdebugenabled for LOG.debug() as noted in MAPREDUCE-1026
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-1236
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1236
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Priority: Minor
>
> in /MAPREDUCE-1026 we introduces few LOG.debug() not constrained by LOG.isdebugenabed() .
> Fixing that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1236) added LOG.isdebugenabled for
LOG.debug() as noted in MAPREDUCE-1026
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781676#action_12781676 ]
Hadoop QA commented on MAPREDUCE-1236:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12425867/MAPREDUCE-1236.patch
against trunk revision 883452.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/150/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/150/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/150/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/150/console
This message is automatically generated.
> added LOG.isdebugenabled for LOG.debug() as noted in MAPREDUCE-1026
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-1236
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1236
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Priority: Minor
> Attachments: MAPREDUCE-1236.patch
>
>
> in /MAPREDUCE-1026 we introduces few LOG.debug() not constrained by LOG.isdebugenabed() .
> Fixing that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1236) added LOG.isdebugenabled for
LOG.debug() as noted in MAPREDUCE-1026
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-1236:
-------------------------------------
Assignee: Boris Shkolnik
Status: Open (was: Patch Available)
Unfortunately, the patch no longer applies.
The guarding of log statements is a little excessive in the most recent patch. Unless it's frequent and/or involves many conversions of non-String types, it's OK to leave it unguarded.
> added LOG.isdebugenabled for LOG.debug() as noted in MAPREDUCE-1026
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-1236
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1236
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: MAPREDUCE-1236.patch
>
>
> in /MAPREDUCE-1026 we introduces few LOG.debug() not constrained by LOG.isdebugenabed() .
> Fixing that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1236) added LOG.isdebugenabled for
LOG.debug() as noted in MAPREDUCE-1026
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781524#action_12781524 ]
Boris Shkolnik commented on MAPREDUCE-1236:
-------------------------------------------
Of course.
The threshold is using at least some construction in the debug message (like "foo" + "bar")
> added LOG.isdebugenabled for LOG.debug() as noted in MAPREDUCE-1026
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-1236
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1236
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Priority: Minor
>
> in /MAPREDUCE-1026 we introduces few LOG.debug() not constrained by LOG.isdebugenabed() .
> Fixing that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1236) added LOG.isdebugenabled for
LOG.debug() as noted in MAPREDUCE-1026
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated MAPREDUCE-1236:
--------------------------------------
Status: Patch Available (was: Open)
> added LOG.isdebugenabled for LOG.debug() as noted in MAPREDUCE-1026
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-1236
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1236
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Priority: Minor
> Attachments: MAPREDUCE-1236.patch
>
>
> in /MAPREDUCE-1026 we introduces few LOG.debug() not constrained by LOG.isdebugenabed() .
> Fixing that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1236) added LOG.isdebugenabled for
LOG.debug() as noted in MAPREDUCE-1026
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781691#action_12781691 ]
Boris Shkolnik commented on MAPREDUCE-1236:
-------------------------------------------
Failed test -TestGridmixSubmission.testSubmit is a known existing problem.
No test included because there is not functional changes.
> added LOG.isdebugenabled for LOG.debug() as noted in MAPREDUCE-1026
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-1236
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1236
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Priority: Minor
> Attachments: MAPREDUCE-1236.patch
>
>
> in /MAPREDUCE-1026 we introduces few LOG.debug() not constrained by LOG.isdebugenabed() .
> Fixing that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.