[GitHub] [zookeeper] jhuan31 commented on a change in pull request #1379: ZOOKEEPER-3859: Add a couple request processor metrics

[GitBox <gi...@apache.org>]

jhuan31 commented on a change in pull request #1379:
URL: https://github.com/apache/zookeeper/pull/1379#discussion_r444494946



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
##########
@@ -118,6 +120,8 @@ public void run() {
                     break;
                 }
             }
+        } catch (RuntimeException e) { // spotbugs require explicit catch of RuntimeException

Review comment:
       The RuntimeException is not exactly "swallowed" here. It is handled as if it were a non-RuntimeException and the zookeeper server is stopped--is it the right thing to do?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org