You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/07/13 20:11:57 UTC
[GitHub] [tinkerpop] simonz-bq commented on a diff in pull request #1754: gremlin-go: fix deadlock on (*DriverRemoteConnection).Close
simonz-bq commented on code in PR #1754:
URL: https://github.com/apache/tinkerpop/pull/1754#discussion_r920462382
##########
gremlin-go/driver/connection.go:
##########
@@ -55,8 +55,10 @@ type connectionSettings struct {
func (connection *connection) errorCallback() {
connection.logHandler.log(Error, errorCallback)
connection.state = closedDueToError
- err := connection.protocol.close()
- if err != nil {
+
+ // This callback is called from within protocol.readLoop. Therefore,
Review Comment:
Can we modify protocol.readLoop?
Simply I would just like all `protocol.wg.Done()` to be removed, and instead added before the `for` as `defer(protocol.wg.Done()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org