[GitHub] [airflow] potiuk commented on a diff in pull request #24910: Automatically detect if non-lazy logging interpolation is used

[GitBox <gi...@apache.org>]

potiuk commented on code in PR #24910:
URL: https://github.com/apache/airflow/pull/24910#discussion_r916592844


##########
scripts/ci/pre_commit/pre_commit_check_lazy_logging.py:
##########
@@ -0,0 +1,79 @@
+#!/usr/bin/env python
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+import ast
+import pathlib
+import re
+import sys
+
+import astor as astor
+from rich.console import Console
+
+console = Console(color_system="standard", width=200)
+
+LOGGIN_MATCHER = re.compile(r'^log.?[a-z]*\.[a-z]*\(f.*["\']')
+SELF_LOG_MATCHER = re.compile(r'^self\.log\.[a-z]*\(f.*["\']')
+
+
+class LogFinder(astor.TreeWalk):
+    module_printed: bool = False
+    name: str = ''
+    error_count = 0
+
+    def pre_Call(self):
+        if isinstance(self.cur_node.func, ast.Attribute) and (
+            isinstance(self.cur_node.func.value, ast.Name)
+            and (
+                self.cur_node.func.value.id == "logger"
+                or self.cur_node.func.value.id == "logging"
+                or self.cur_node.func.value.id == "log"
+            )
+            or (self.cur_node.func.attr in ['debug', 'warning', 'info', "error", "critical"])

Review Comment:
   Right.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org