[GitHub] merlimat commented on a change in pull request #2054: Package Pulsar IO connectors into separate tgz in form of nar archives

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #2054: Package Pulsar IO connectors into separate tgz in form of nar archives
URL: https://github.com/apache/incubator-pulsar/pull/2054#discussion_r200464029
 
 

 ##########
 File path: pulsar-io/kinesis/pom.xml
 ##########
 @@ -83,36 +83,12 @@
 	<!-- /kinesis dependencies -->
 
   </dependencies>
-  
+
   <build>
     <plugins>
       <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
 
 Review comment:
   @rdhabalia I'm working on the subsequent part of the change. 
   
   The goal is to have a Nar archive for each connector that contains the connector classes + all the jar dependencies. 
   
   This will make it easier to distribute and submit connectors, and also avoiding the shading problem and conflicts, since the Nar gets upacked in the worker it will be using its own classloader, limited to what it carries inside (plus `java-instance.jar`). 
   
   I have the PR almost ready for the 1st step: 
    1. Accept nar when submitting connector (and unpack it, if needed and then cache it, when the function runs
    2. Next step would be to assume connector nars are already present in worker, therefore when submitting a connector, we just need to specify the type, eg: "kinesis" and we can validate whether that's a supported connector or not.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services