[jira] Commented: (SMX4KNL-152) The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own

["Guillaume Nodet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/activemq/browse/SMX4KNL-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48224#action_48224 ] 

Guillaume Nodet commented on SMX4KNL-152:
-----------------------------------------

So the goal is to be able to display informations about the application using an embedded ServiceMix Kernel.
The first obvious example is the full Smx4 distribution, which has a different version.
I guess the kernel should display its own version along with the version of the embedding application.
So there are two places that are affected: the banner displayed when the console is started and the Info command.
I'm not sure that using a properties file from the kit is the way to go, i would rather try to use a file embedded in a jar
instead, as such informations are not supposed to be changed by the end user.

So we need to define somewhere a location that will be looked by the kernel to load the attributes of the branding.
In the InfoAction class, we need to display both the kernel version and the application version if it has been defined.
Note that currently, the kernel version is hardcoded in the gshell.xml spring config file and should be retrieved 
from the servicemix-version.properties file instead ...

Remember that in OSGi, access to resources is limited by the way the classloader is set up, so it might make sense
to first try with a plain property file in a known location like ${servicemix.home}/etc, and then figure out if we can use
resources for that.

> The version number displayed in the console should be extract from resources (using maven filtering + properties file) but the branding should be easy to change so that people embedding the Kernel can define their own
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4KNL-152
>                 URL: https://issues.apache.org/activemq/browse/SMX4KNL-152
>             Project: ServiceMix Kernel
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Assignee: Edell Nolan
>             Fix For: 1.1.0
>
>
> Hi Guillaume,
> I have done some initial work around this but wanted to check that I am on the right track.
> Do we want to take the brandName, Version and the banner from a properties file that will be located in the kit ?
> thanks, Edell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.