You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by di...@apache.org on 2006/11/03 22:04:35 UTC

svn commit: r470991 - /webservices/axis2/branches/java/1_1/modules/kernel/src/org/apache/axis2/deployment/ServiceBuilder.java

Author: dims
Date: Fri Nov  3 13:04:34 2006
New Revision: 470991

URL: http://svn.apache.org/viewvc?view=rev&rev=470991
Log:
- Change the throw to log.info (not sure if *ALL* scenarios need ServiceClass)
- Remove tabs, fix comment
- Don't have to add the JIRA # everywhere, it can be retrieved from SVN history if needed.


Modified:
    webservices/axis2/branches/java/1_1/modules/kernel/src/org/apache/axis2/deployment/ServiceBuilder.java

Modified: webservices/axis2/branches/java/1_1/modules/kernel/src/org/apache/axis2/deployment/ServiceBuilder.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_1/modules/kernel/src/org/apache/axis2/deployment/ServiceBuilder.java?view=diff&rev=470991&r1=470990&r2=470991
==============================================================================
--- webservices/axis2/branches/java/1_1/modules/kernel/src/org/apache/axis2/deployment/ServiceBuilder.java (original)
+++ webservices/axis2/branches/java/1_1/modules/kernel/src/org/apache/axis2/deployment/ServiceBuilder.java Fri Nov  3 13:04:34 2006
@@ -94,22 +94,16 @@
             OMAttribute serviceNameatt = service_element.getAttribute(new QName(ATTRIBUTE_NAME));
             
             // If the service name is explicitly specified in the services.xml
-            // then lets use that as the service name
-            // Refer jira AXIS2-1569
-
+            // then use that as the service name
             if (serviceNameatt != null) {
-                if (!"".equals(serviceNameatt.getAttributeValue().trim())) {                	
-                	// Refer AXIS2-1569
-                	service.setName(serviceNameatt.getAttributeValue());
+                if (!"".equals(serviceNameatt.getAttributeValue().trim())) {
+                    service.setName(serviceNameatt.getAttributeValue());
                     service.setServiceDescription(serviceNameatt.getAttributeValue());
                 }
             }
             
-            // I am delaying the checking of the ServiceClass param until the service name
-            // is processed so that I can throw a more meaningful exception that will help
-            // identify the problem
             if (service.getParameter("ServiceClass") == null){
-            	throw new DeploymentException("The Service " + service.getName() + " does not specify a Service Class");
+                log.info("The Service " + service.getName() + " does not specify a Service Class");
             }
             
             // Process WS-Addressing flag attribute



---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org