You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alan Conway (JIRA)" <ji...@apache.org> on 2018/05/29 13:34:00 UTC
[jira] [Reopened] (DISPATCH-921) Install console dependencies with
npm during make install
[ https://issues.apache.org/jira/browse/DISPATCH-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Conway reopened DISPATCH-921:
----------------------------------
I don't think breaking the upstream installer for the convenience of downstream packaging is the right solution. The attached patch puts the NPM files back into the installer, but can easily be disabled by packagers with `cmake -DCONSOLE_NPM_INSTALL=NO`.
However when we do make a downstream package will will need to package a predictable version of the console dependencies so I don't think we will want to disable the NPM install. Rather we will want to specify exact NPM versions in the repository an allow those predictable, reproducible, traceable versions to be installed and packaged with the rest of the code.
> Install console dependencies with npm during make install
> ---------------------------------------------------------
>
> Key: DISPATCH-921
> URL: https://issues.apache.org/jira/browse/DISPATCH-921
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Console
> Affects Versions: 1.0.0
> Reporter: Ernest Allen
> Assignee: Ernest Allen
> Priority: Major
> Fix For: 1.1.0
>
> Attachments: 0001-NEED-JIRA-install-NPM-files-automatically-as-part-of.patch
>
>
> During a make install, the stand-alone console's dependencies should be installed using the command 'npm install' executed from the console's install directory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org