You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/10/11 06:04:34 UTC
[GitHub] [inlong] thesumery commented on a diff in pull request #6123: [INLONG-6116][Sort] Support dynamic topic for KafkaLoadNode
thesumery commented on code in PR #6123:
URL: https://github.com/apache/inlong/pull/6123#discussion_r991847775
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -86,25 +86,30 @@ public final class Constants {
public static final String INLONG_METRIC_STATE_NAME = "inlong-metric-states";
public static final ConfigOption<String> INLONG_METRIC =
- ConfigOptions.key("inlong.metric.labels")
- .stringType()
- .noDefaultValue()
- .withDescription("INLONG metric labels, format is 'key1=value1&key2=value2',"
- + "default is 'groupId=xxx&streamId=xxx&nodeId=xxx'");
+ ConfigOptions.key("inlong.metric.labels")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("INLONG metric labels, format is 'key1=value1&key2=value2',"
+ + "default is 'groupId=xxx&streamId=xxx&nodeId=xxx'");
public static final ConfigOption<String> INLONG_AUDIT =
- ConfigOptions.key("metrics.audit.proxy.hosts")
- .stringType()
- .noDefaultValue()
- .withDescription("Audit proxy host address for reporting audit metrics. \n"
- + "e.g. 127.0.0.1:10081,0.0.0.1:10081");
+ ConfigOptions.key("metrics.audit.proxy.hosts")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("Audit proxy host address for reporting audit metrics. \n"
+ + "e.g. 127.0.0.1:10081,0.0.0.1:10081");
public static final ConfigOption<Boolean> IGNORE_ALL_CHANGELOG =
ConfigOptions.key("sink.ignore.changelog")
.booleanType()
.defaultValue(false)
.withDescription("Regard upsert delete as insert kind.");
+ public static final ConfigOption<String> INNER_FORMAT =
+ ConfigOptions.key("inner.format")
Review Comment:
how about 'sink.multiple.format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org