[GitHub] [activemq-artemis] franz1981 commented on issue #2771: ARTEMIS-2434 Don't lock ServerConsumerImpl for long period of time

[GitBox <gi...@apache.org>]

franz1981 commented on issue #2771: ARTEMIS-2434 Don't lock ServerConsumerImpl for long period of time
URL: https://github.com/apache/activemq-artemis/pull/2771#issuecomment-515517273
 
 
   I have yet to verify that it works good on our CI: the only downside of this solution is that the lock won't be fairly attempted on `tryLock` if compared with an explicit timed `lock`.
   I don't think this would be a problem, given that `setStarted` and `setTransferring` are slow path operations (ie rollback and connection transfert) and will be performend at least 300 times (every 100 ms for 30 seconds), the chance that they won't enter the lock is very small.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services