You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2020/10/08 11:55:19 UTC
svn commit: r1882318 - in /subversion/branches/1.14.x: STATUS
subversion/tests/libsvn_repos/repos-test.c
Author: stsp
Date: Thu Oct 8 11:55:19 2020
New Revision: 1882318
URL: http://svn.apache.org/viewvc?rev=1882318&view=rev
Log:
* STATUS: Remove r1882186 nomination.
The proposed change introduces a regression where behaviour
of trunk differs from both 1.9 and 1.10:
http://mail-archives.apache.org/mod_mbox/subversion-dev/202010.mbox/%3C20201006162606.GA86427%40byrne.stsp.name%3E
Modified:
subversion/branches/1.14.x/STATUS
subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c
Modified: subversion/branches/1.14.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1882318&r1=1882317&r2=1882318&view=diff
==============================================================================
--- subversion/branches/1.14.x/STATUS (original)
+++ subversion/branches/1.14.x/STATUS Thu Oct 8 11:55:19 2020
@@ -69,14 +69,6 @@ Candidate changes:
The --help message for several commands is misleading. User complained.
Votes:
+1: stsp
-
- * r1882186
- Fix issue #4762 "authz doesn't combine global and repository rules"
- Justification:
- Backwards-incompatible change introduced in SVN 1.10. Users complained.
- https://issues.apache.org/jira/browse/SVN-4762
- Votes:
- +1: stsp
Veto-blocked changes:
=====================
Modified: subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c
URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c?rev=1882318&r1=1882317&r2=1882318&view=diff
==============================================================================
--- subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c (original)
+++ subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c Thu Oct 8 11:55:19 2020
@@ -1641,6 +1641,9 @@ test_authz_prefixes(apr_pool_t *pool)
contents = apr_psprintf(iterpool, contents_format,
glob1, repo1, test_path,
glob2, repo2, test_path);
+ fprintf(stderr, "testing authz %d:\n[[[\n", combi);
+ fprintf(stderr, "%s", contents);
+ fprintf(stderr, "]]]\n");
SVN_ERR(authz_get_handle(&authz_cfg, contents, FALSE, iterpool));
/* iterate over all test paths */
Re: svn commit: r1882318 - in /subversion/branches/1.14.x: STATUS
subversion/tests/libsvn_repos/repos-test.c
Posted by Stefan Sperling <st...@apache.org>.
On Thu, Oct 08, 2020 at 03:24:33PM +0200, Johan Corveleyn wrote:
> > Modified: subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c
> > URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c?rev=1882318&r1=1882317&r2=1882318&view=diff
> > ==============================================================================
> > --- subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c (original)
> > +++ subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c Thu Oct 8 11:55:19 2020
> > @@ -1641,6 +1641,9 @@ test_authz_prefixes(apr_pool_t *pool)
> > contents = apr_psprintf(iterpool, contents_format,
> > glob1, repo1, test_path,
> > glob2, repo2, test_path);
> > + fprintf(stderr, "testing authz %d:\n[[[\n", combi);
> > + fprintf(stderr, "%s", contents);
> > + fprintf(stderr, "]]]\n");
>
> ^ scalpel ?
Indeed. Reverted now. Thanks for spotting this :)
Re: svn commit: r1882318 - in /subversion/branches/1.14.x: STATUS subversion/tests/libsvn_repos/repos-test.c
Posted by Johan Corveleyn <jc...@gmail.com>.
On Thu, Oct 8, 2020 at 2:22 PM <st...@apache.org> wrote:
>
> Author: stsp
> Date: Thu Oct 8 11:55:19 2020
> New Revision: 1882318
>
> URL: http://svn.apache.org/viewvc?rev=1882318&view=rev
> Log:
> * STATUS: Remove r1882186 nomination.
>
> The proposed change introduces a regression where behaviour
> of trunk differs from both 1.9 and 1.10:
> http://mail-archives.apache.org/mod_mbox/subversion-dev/202010.mbox/%3C20201006162606.GA86427%40byrne.stsp.name%3E
>
> Modified:
> subversion/branches/1.14.x/STATUS
> subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c
<snip>
> Modified: subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c
> URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c?rev=1882318&r1=1882317&r2=1882318&view=diff
> ==============================================================================
> --- subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c (original)
> +++ subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c Thu Oct 8 11:55:19 2020
> @@ -1641,6 +1641,9 @@ test_authz_prefixes(apr_pool_t *pool)
> contents = apr_psprintf(iterpool, contents_format,
> glob1, repo1, test_path,
> glob2, repo2, test_path);
> + fprintf(stderr, "testing authz %d:\n[[[\n", combi);
> + fprintf(stderr, "%s", contents);
> + fprintf(stderr, "]]]\n");
^ scalpel ?
--
Johan