[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #776: Report a failure fast if `CMAKE_OSX_DEPLOYMENT_TARGET` unset on MacOS

[GitBox <gi...@apache.org>]

PragmaTwice commented on issue #776:
URL: https://github.com/apache/incubator-kvrocks/issues/776#issuecomment-1240216812

   > Hi. I am using MacBook M1. According to [341a989#r80998035](https://github.com/apache/incubator-kvrocks/commit/341a989d75783d8dad76bbd5a4473dd345472337#r80998035), If I replace `${CMAKE_OSX_DEPLOYMENT_TARGET}` with `11.0`, The compilation can be successful. I am not very familiar with cmake. Do you have time to repair it? I noticed that you don't have an apple device to test. I can compile and test for you. @PragmaTwice
   
   Hi @tanruixiang, actually you can directly pass the option to cmake, e.g. `cmake -DCMAKE_OSX_DEPLOYMENT_TARGET=10.3 ..`, `MACOSX_DEPLOYMENT_TARGET=10.3 cmake ..` or `./x.py build  -DCMAKE_OSX_DEPLOYMENT_TARGET=10.3` rather than modifying cmake files.
   
   If you want to try to fix this problem, you can add an `if ... else ...` to CMakeLists, i.e. when it is currently in macos and `CMAKE_OSX_DEPLOYMENT_TARGET` is not configured, an error should be reported and the user will be reminded to configure it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org