You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/01 07:53:07 UTC
[GitHub] [tvm] ZQPei opened a new pull request #9619: [BugFix][Micro] fix tvm.micro ImportError in tvmc when USE_MICRO is OFF
ZQPei opened a new pull request #9619:
URL: https://github.com/apache/tvm/pull/9619
As discussed in issue https://github.com/apache/tvm/issues/9617.
Recently `tvm.micro` is imported by tvmc even though `USE_MICRO` macro is `OFF`.
This bug was mistakenly introduced by https://github.com/apache/tvm/pull/9229.
As we can see in
https://github.com/apache/tvm/blob/32e80128d195db9987e47a89755f4ef4d7cf8e8d/python/tvm/driver/tvmc/__init__.py#L22
and
https://github.com/apache/tvm/blob/32e80128d195db9987e47a89755f4ef4d7cf8e8d/python/tvm/driver/tvmc/runner.py#L37-L39
I tried to fix it by,
- adding a `check_micro_support` api to `tvm.support`,
- lazy import `tvm.micro` after `check_micro_support` to preserve tvm with USE_MICRO OFF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ZQPei commented on pull request #9619: [BugFix][Micro] fix tvm.micro ImportError in tvmc when USE_MICRO is OFF
Posted by GitBox <gi...@apache.org>.
ZQPei commented on pull request #9619:
URL: https://github.com/apache/tvm/pull/9619#issuecomment-985114737
> @ZQPei if you're happy with the other PR, shall we close this PR and move forward with the other?
Yes, of course
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ZQPei commented on pull request #9619: [BugFix][Micro] fix tvm.micro ImportError in tvmc when USE_MICRO is OFF
Posted by GitBox <gi...@apache.org>.
ZQPei commented on pull request #9619:
URL: https://github.com/apache/tvm/pull/9619#issuecomment-984283398
> I'm wondering if you could kindly test it too and check if it also fixes your issue.
>
> My take is that `tvmc micro` parser should not be generated when USE_MICRO=OFF and also `--device micro` should be made unavailable for the user, saying why that's not supported.
Yeah, looks good to me. It can also fix the issue and is more concise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ZQPei closed pull request #9619: [BugFix][Micro] fix tvm.micro ImportError in tvmc when USE_MICRO is OFF
Posted by GitBox <gi...@apache.org>.
ZQPei closed pull request #9619:
URL: https://github.com/apache/tvm/pull/9619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #9619: [BugFix][Micro] fix tvm.micro ImportError in tvmc when USE_MICRO is OFF
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #9619:
URL: https://github.com/apache/tvm/pull/9619#issuecomment-984800169
> > I'm wondering if you could kindly test it too and check if it also fixes your issue.
> > My take is that `tvmc micro` parser should not be generated when USE_MICRO=OFF and also `--device micro` should be made unavailable for the user, saying why that's not supported.
>
> Yeah, looks good to me. It can also fix the issue and is more concise.
@ZQPei :+1: Thanks for the review and for checking that it fixes your issue too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #9619: [BugFix][Micro] fix tvm.micro ImportError in tvmc when USE_MICRO is OFF
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on pull request #9619:
URL: https://github.com/apache/tvm/pull/9619#issuecomment-984870440
@ZQPei if you're happy with the other PR, shall we close this PR and move forward with the other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero edited a comment on pull request #9619: [BugFix][Micro] fix tvm.micro ImportError in tvmc when USE_MICRO is OFF
Posted by GitBox <gi...@apache.org>.
gromero edited a comment on pull request #9619:
URL: https://github.com/apache/tvm/pull/9619#issuecomment-984242581
@ZQPei oh pardon, even with @leandron tagging me I missed that PR. Thanks for reporting and proposing a fix.
Since I was not aware of yours I created earlier today https://github.com/apache/tvm/pull/9632
I'm wondering if you could kindly test it too and check if it also fixes your issue.
My take is that `tvmc micro` parser should not be generated when USE_MICRO=OFF and also `--device micro` should be made unavailable for the user, saying why that's not supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #9619: [BugFix][Micro] fix tvm.micro ImportError in tvmc when USE_MICRO is OFF
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #9619:
URL: https://github.com/apache/tvm/pull/9619#issuecomment-984242581
@ZQPei oh pardon, even with @leandron tagging me I missed that PR. Thanks for reporting and proposing a fix.
Since I was not aware of yours I created earlier today https://github.com/apache/tvm/pull/9632
I'm wondering if you could kindly test it too and check if it also fixes your issue.
My take is that `tvmc micro` parser should be not generated when USE_MICRO=OFF and also `--device micro` should be made unavailable for the user, saying why that's not supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org