You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/08/30 09:56:56 UTC
[GitHub] [beam] scwhittle opened a new pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
scwhittle opened a new pull request #15416:
URL: https://github.com/apache/beam/pull/15416
This ensures that files have distributed prefix that is common across pipeline executions and thus can reuse GCS autoscaling of the file metadata.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
`ValidatesRunner` compliance status (on master branch)
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/badge/icon?subject=V1+Streaming">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon?subject=V1+Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/badge/icon?subject=V2+Streaming">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon?subject=Java+8">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon?subject=Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon?subject=Portable+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/badge/icon?subject=Portable">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon?subject=Structured+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon?subject=ValCont">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
</tbody>
</table>
Examples testing status on various runners
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/badge/icon?subject=V1+Java11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
Post-Commit SDK/Transform Integration Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>Go</th>
<th>Java</th>
<th>Python</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon?subject=3.6">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon?subject=3.7">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon?subject=3.8">
</a>
</td>
</tr>
</tbody>
</table>
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>---</th>
<th>Java</th>
<th>Python</th>
<th>Go</th>
<th>Website</th>
<th>Whitespace</th>
<th>Typescript</th>
</tr>
</thead>
<tbody>
<tr>
<td>Non-portable</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon?subject=Tests">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon?subject=Lint">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon?subject=Docker">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon?subject=Docs">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Portable</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed temporary files to consistent temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-951295022
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-937828932
I was unable to reproduce the error when I ran on my machine.
I have not had time to investigate further. Given that this isn't ready to
merge I don't think it should be a blocker for the release.
On Wed, Oct 6, 2021 at 8:33 PM Chamikara Jayalath ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
> <https://github.com/apache/beam/pull/15416#discussion_r723575029>:
>
> > @@ -556,25 +565,35 @@ public ResourceId apply(ResourceId tempDirectory) {
> */
> @Experimental(Kind.FILESYSTEM)
> public WriteOperation(FileBasedSink<?, DestinationT, OutputT> sink, ResourceId tempDirectory) {
> - this(sink, StaticValueProvider.of(tempDirectory));
> + this(sink, StaticValueProvider.of(tempDirectory), false);
>
> Any updates ?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/15416#discussion_r723575029>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABBZZTDQXCI5NBVGDD3ZMXDUFSJABANCNFSM5DBQT3KA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #15416: [BEAM-12818] Write windowed temporary files to consistent temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-971797869
Can we close out BEAM-12818 now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #15416: [BEAM-12818] Write windowed temporary files to consistent temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-956495130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj removed a comment on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
chamikaramj removed a comment on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-921091762
Sorry, wrong PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on a change in pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on a change in pull request #15416:
URL: https://github.com/apache/beam/pull/15416#discussion_r719138472
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
##########
@@ -522,16 +526,17 @@ protected static ResourceId buildTemporaryFilename(ResourceId tempDirectory, Str
* Constructs a WriteOperation using the default strategy for generating a temporary directory
* from the base output filename.
*
- * <p>Default is a uniquely named subdirectory of the provided tempDirectory, e.g. if
- * tempDirectory is /path/to/foo/, the temporary directory will be
+ * <p>Without windowing, the default is a uniquely named subdirectory of the provided
+ * tempDirectory, e.g. if tempDirectory is /path/to/foo/, the temporary directory will be
* /path/to/foo/.temp-beam-$uuid.
*
+ * <p>With windowing, the default is to use tempDirectory directly.
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed temporary files to consistent temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-971914388
Yes, resolved that.
On Wed, Nov 17, 2021 at 6:28 PM tvalentyn ***@***.***> wrote:
> Can we close out BEAM-12818
> <https://issues.apache.org/jira/browse/BEAM-12818> now?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/15416#issuecomment-971797869>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABBZZTE4X7UATKGEQLRARODUMPQZ7ANCNFSM5DBQT3KA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a change in pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on a change in pull request #15416:
URL: https://github.com/apache/beam/pull/15416#discussion_r718788980
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
##########
@@ -522,16 +526,17 @@ protected static ResourceId buildTemporaryFilename(ResourceId tempDirectory, Str
* Constructs a WriteOperation using the default strategy for generating a temporary directory
* from the base output filename.
*
- * <p>Default is a uniquely named subdirectory of the provided tempDirectory, e.g. if
- * tempDirectory is /path/to/foo/, the temporary directory will be
+ * <p>Without windowing, the default is a uniquely named subdirectory of the provided
+ * tempDirectory, e.g. if tempDirectory is /path/to/foo/, the temporary directory will be
* /path/to/foo/.temp-beam-$uuid.
*
+ * <p>With windowing, the default is to use tempDirectory directly.
Review comment:
Can we explain why we do this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-931810010
Unfortunately the same test keeps failing. Trying again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-949166609
@scwhittle - should we close this? Are you still planning to work on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed temporary files to consistent temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-950939379
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-921091570
Could these failures be related ?
https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/18864/testReport/junit/org.apache.beam.sdk.io/TextIOReadTest$BasicIOTest/testReadWatchForNewFiles/
https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/18864/testReport/junit/org.apache.beam.sdk.io.contextualtextio/ContextualTextIOTest$BasicIOTest/testReadWatchForNewFiles/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed temporary files to consistent temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-971727368
Run Java_Examples_Dataflow PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #15416: [BEAM-12818] Write windowed temporary files to consistent temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-956508759
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a change in pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on a change in pull request #15416:
URL: https://github.com/apache/beam/pull/15416#discussion_r719875710
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
##########
@@ -556,25 +565,35 @@ public ResourceId apply(ResourceId tempDirectory) {
*/
@Experimental(Kind.FILESYSTEM)
public WriteOperation(FileBasedSink<?, DestinationT, OutputT> sink, ResourceId tempDirectory) {
- this(sink, StaticValueProvider.of(tempDirectory));
+ this(sink, StaticValueProvider.of(tempDirectory), false);
Review comment:
Shouldn't this be "true" ? This might also explain the failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-930396531
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-908250589
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on a change in pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on a change in pull request #15416:
URL: https://github.com/apache/beam/pull/15416#discussion_r735607227
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
##########
@@ -556,25 +565,35 @@ public ResourceId apply(ResourceId tempDirectory) {
*/
@Experimental(Kind.FILESYSTEM)
public WriteOperation(FileBasedSink<?, DestinationT, OutputT> sink, ResourceId tempDirectory) {
- this(sink, StaticValueProvider.of(tempDirectory));
+ this(sink, StaticValueProvider.of(tempDirectory), false);
Review comment:
I believe this is fixed, see other comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #15416: [BEAM-12818] Write windowed temporary files to consistent temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-956508416
LGTM. Thanks.
We can merge when tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-931513295
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on a change in pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on a change in pull request #15416:
URL: https://github.com/apache/beam/pull/15416#discussion_r720188218
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
##########
@@ -556,25 +565,35 @@ public ResourceId apply(ResourceId tempDirectory) {
*/
@Experimental(Kind.FILESYSTEM)
public WriteOperation(FileBasedSink<?, DestinationT, OutputT> sink, ResourceId tempDirectory) {
- this(sink, StaticValueProvider.of(tempDirectory));
+ this(sink, StaticValueProvider.of(tempDirectory), false);
Review comment:
The failures seem relevant as the test also performs a write before reading.
Trying to reproduce locally so I can debug. I'm wondering if it is failing since it is trying to write to some protected dir in tests or a directory needs to be created.
I don't think that should be true there because the previous behavior was to not subdirectory, as the staticvalueprovider was used instead of the TemporaryDirectoryBuilder provider that created the subdir used by other constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-921091762
Sorry, wrong PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-950868903
I lost track of this, working on fixing the tests now.
On Fri, Oct 22, 2021 at 3:24 AM Ahmet Altay ***@***.***>
wrote:
> @scwhittle <https://github.com/scwhittle> - should we close this? Are you
> still planning to work on it?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/15416#issuecomment-949166609>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABBZZTGFAP6J7B2G7LBFGSLUIC4OLANCNFSM5DBQT3KA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-950935938
R: @chamikaramj PTAL, I believe this addresses the test failures.
The test failures were arising due to the test not specifying a temporary directory for output. The default behavior in this case is to use the output directory as the temporary directory. This didn't work with the previous cl because the temporary files themselves showed up in the output directory then. I modified the PR so that we continue to use a subdirectory for temporary files when we were before, what changes is if that subdirectory is unique for the execution or if it is consistent across executions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-937828932
I was unable to reproduce the error when I ran on my machine.
I have not had time to investigate further. Given that this isn't ready to
merge I don't think it should be a blocker for the release.
On Wed, Oct 6, 2021 at 8:33 PM Chamikara Jayalath ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
> <https://github.com/apache/beam/pull/15416#discussion_r723575029>:
>
> > @@ -556,25 +565,35 @@ public ResourceId apply(ResourceId tempDirectory) {
> */
> @Experimental(Kind.FILESYSTEM)
> public WriteOperation(FileBasedSink<?, DestinationT, OutputT> sink, ResourceId tempDirectory) {
> - this(sink, StaticValueProvider.of(tempDirectory));
> + this(sink, StaticValueProvider.of(tempDirectory), false);
>
> Any updates ?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/15416#discussion_r723575029>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABBZZTDQXCI5NBVGDD3ZMXDUFSJABANCNFSM5DBQT3KA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #15416: [BEAM-12818] Write windowed temporary files to consistent temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
tvalentyn merged pull request #15416:
URL: https://github.com/apache/beam/pull/15416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed temporary files to consistent temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-971510472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a change in pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on a change in pull request #15416:
URL: https://github.com/apache/beam/pull/15416#discussion_r718788980
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
##########
@@ -522,16 +526,17 @@ protected static ResourceId buildTemporaryFilename(ResourceId tempDirectory, Str
* Constructs a WriteOperation using the default strategy for generating a temporary directory
* from the base output filename.
*
- * <p>Default is a uniquely named subdirectory of the provided tempDirectory, e.g. if
- * tempDirectory is /path/to/foo/, the temporary directory will be
+ * <p>Without windowing, the default is a uniquely named subdirectory of the provided
+ * tempDirectory, e.g. if tempDirectory is /path/to/foo/, the temporary directory will be
* /path/to/foo/.temp-beam-$uuid.
*
+ * <p>With windowing, the default is to use tempDirectory directly.
Review comment:
Can we explain why we do this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-930396873
I don't think those are related since those are reading not writing, rerunning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a change in pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on a change in pull request #15416:
URL: https://github.com/apache/beam/pull/15416#discussion_r723575029
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
##########
@@ -556,25 +565,35 @@ public ResourceId apply(ResourceId tempDirectory) {
*/
@Experimental(Kind.FILESYSTEM)
public WriteOperation(FileBasedSink<?, DestinationT, OutputT> sink, ResourceId tempDirectory) {
- this(sink, StaticValueProvider.of(tempDirectory));
+ this(sink, StaticValueProvider.of(tempDirectory), false);
Review comment:
Any updates ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-930396531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #15416: [BEAM-12818] Write windowed temporary files to consistent temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-956495130
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-908208527
R: @chamikaramj @reuvenlax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-921090173
@chamikaramj @reuvenlax - Could you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org