You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by juergenthomann <gi...@git.apache.org> on 2017/05/03 11:17:23 UTC
[GitHub] flink pull request #3813: [FLINK-6427] Ensure file length is flushed in Stre...
GitHub user juergenthomann opened a pull request:
https://github.com/apache/flink/pull/3813
[FLINK-6427] Ensure file length is flushed in StreamWriterBase
StreamWriterBase is used with BucketingSink. With HDFS, it can happen that the NameNode does not know about the current file length if we flush but don't properly close the file. We now specify that we also want to update the file length when syncing a Stream.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/juergenthomann/flink bucketing-sink-flush-file-length
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3813.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3813
----
commit 83799ce096e54e0590aa1d79b37dec8ff4300e2e
Author: Jürgen Thomann <ju...@innogames.com>
Date: 2017-05-03T11:06:04Z
[FLINK-6427] Ensure file length is flushed in StreamWriterBase
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3813: [FLINK-6427] Ensure file length is flushed in StreamWrite...
Posted by juergenthomann <gi...@git.apache.org>.
Github user juergenthomann commented on the issue:
https://github.com/apache/flink/pull/3813
Thanks for merging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3813: [FLINK-6427] Ensure file length is flushed in Stre...
Posted by juergenthomann <gi...@git.apache.org>.
Github user juergenthomann closed the pull request at:
https://github.com/apache/flink/pull/3813
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3813: [FLINK-6427] Ensure file length is flushed in StreamWrite...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3813
@juergenthomann you tested this in your program, correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3813: [FLINK-6427] Ensure file length is flushed in StreamWrite...
Posted by juergenthomann <gi...@git.apache.org>.
Github user juergenthomann commented on the issue:
https://github.com/apache/flink/pull/3813
@aljoscha I tested it now 3 times and always the valid length was equal or smaller than the file size reported by the namenode. So for me it works perfectly fine now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3813: [FLINK-6427] Ensure file length is flushed in StreamWrite...
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3813
No objections from my side. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3813: [FLINK-6427] Ensure file length is flushed in StreamWrite...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3813
Merged. 👍 @juergenthomann could you please close this PR?
Thanks for fixing this and finding and debugging it in the first place!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3813: [FLINK-6427] Ensure file length is flushed in StreamWrite...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3813
This looks good to me. @StefanRRichter do you have an opinion on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---