You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/12/13 05:25:28 UTC
Review Request 16237: Moved slave state API functions to the top of the
header.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16237/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-844
https://issues.apache.org/jira/browse/MESOS-844
Repository: mesos-git
Description
-------
Seems as though these API functions belong at the top of the header, not at the bottom.
Diffs
-----
src/slave/state.hpp f06cba8b9b197ea40e6c255e158d920b4ba602ff
Diff: https://reviews.apache.org/r/16237/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 16237: Moved slave state API functions to the top of the
header.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16237/#review30424
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Dec. 13, 2013, 4:25 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16237/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 4:25 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-844
> https://issues.apache.org/jira/browse/MESOS-844
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Seems as though these API functions belong at the top of the header, not at the bottom.
>
>
> Diffs
> -----
>
> src/slave/state.hpp f06cba8b9b197ea40e6c255e158d920b4ba602ff
>
> Diff: https://reviews.apache.org/r/16237/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>