You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/02 13:01:02 UTC

[GitHub] [arrow] wesm commented on a change in pull request #7310: ARROW-6052: [C++] Split up arrow/array.h/cc into multiple files under arrow/array/, move ArrayData to separate header, make ArrayData::dictionary ArrayData

wesm commented on a change in pull request #7310:
URL: https://github.com/apache/arrow/pull/7310#discussion_r433855919



##########
File path: cpp/src/arrow/compute/exec.h
##########
@@ -36,6 +36,7 @@
 namespace arrow {
 
 class Array;
+class BooleanArray;

Review comment:
       Note: IWYU unfortunately doesn't recognize forward declarations (https://github.com/include-what-you-use/include-what-you-use/issues/530) but we can add mappings to build-support/iwyu/mappings/arrow-misc.imp to attribute symbols to type_fwd.h so it won't complain about them. I'll fill up these mappings incrementally to help 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org