You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2019/03/05 23:43:22 UTC
[kudu-CR](gh-pages) Use bash instead of shell highlighting in blog post
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12667
to review the following change.
Change subject: Use bash instead of shell highlighting in blog post
......................................................................
Use bash instead of shell highlighting in blog post
Without this change, I get the following error when running
`site_tool jekyll serve`:
$ ./site_tool jekyll serve
The Gemfile's dependencies are satisfied
Configuration file: /home/mpercy/src/kudu-site/_config.yml
Source: /home/mpercy/src/kudu-site
Destination: /home/mpercy/src/kudu-site/_site
Generating...
/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/posix-spawn-0.3.11/lib/posix/spawn.rb:467: warning: constant ::Fixnum is deprecated
Liquid Exception: Traceback (most recent call last): File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 303, in start res = self.get_data(method, lexer, args, kwargs, text) File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 171, in get_data res = self.highlight_text(text, lexer, formatter_name, args, _convert_keys(opts)) File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 122, in highlight_text lexer = self.return_lexer(lexer, args, kwargs, code) File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 79, in return_lexer return lexers.get_lexer_by_name(lexer, **inputs) File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/vendor/pygments-main/pygments/lexers/__init__.py", line 95, in get_lexer_by_name for cls in find_plugin_lexers(): File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/vendor/pygments-main/pygments/plugin.py", line 53, in find_plugin_lexers yield entrypoint.load() File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2323, in load self.require(*args, **kwargs) File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2346, in require items = working_set.resolve(reqs, env, installer, extras=self.extras) File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 778, in resolve raise DistributionNotFound(req, requirers) DistributionNotFound: The 'pygments' distribution was not found and is required by the application in _posts/2019-03-05-transparent-hierarchical-storage-management-with-apache-kudu-and-impala.md
jekyll 2.5.3 | Error: Traceback (most recent call last):
File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 303, in start
res = self.get_data(method, lexer, args, kwargs, text)
File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 171, in get_data
res = self.highlight_text(text, lexer, formatter_name, args, _convert_keys(opts))
File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 122, in highlight_text
lexer = self.return_lexer(lexer, args, kwargs, code)
File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 79, in return_lexer
return lexers.get_lexer_by_name(lexer, **inputs)
File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/vendor/pygments-main/pygments/lexers/__init__.py", line 95, in get_lexer_by_name
for cls in find_plugin_lexers():
File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/vendor/pygments-main/pygments/plugin.py", line 53, in find_plugin_lexers
yield entrypoint.load()
File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2323, in load
self.require(*args, **kwargs)
File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2346, in require
items = working_set.resolve(reqs, env, installer, extras=self.extras)
File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 778, in resolve
raise DistributionNotFound(req, requirers)
DistributionNotFound: The 'pygments' distribution was not found and is required by the application
After changing {% highlight shell %} to {% highlight bash %}, the site
is generated without errors.
Change-Id: I4beafc5c5e272f304a3cc9a44282e80715bea3e5
---
M _posts/2019-03-05-transparent-hierarchical-storage-management-with-apache-kudu-and-impala.md
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/12667/1
--
To view, visit http://gerrit.cloudera.org:8080/12667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4beafc5c5e272f304a3cc9a44282e80715bea3e5
Gerrit-Change-Number: 12667
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR](gh-pages) Use bash instead of shell highlighting in blog post
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12667 )
Change subject: Use bash instead of shell highlighting in blog post
......................................................................
Use bash instead of shell highlighting in blog post
Without this change, I get the following error when running
`site_tool jekyll serve`:
$ ./site_tool jekyll serve
The Gemfile's dependencies are satisfied
Configuration file: /home/mpercy/src/kudu-site/_config.yml
Source: /home/mpercy/src/kudu-site
Destination: /home/mpercy/src/kudu-site/_site
Generating...
/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/posix-spawn-0.3.11/lib/posix/spawn.rb:467: warning: constant ::Fixnum is deprecated
Liquid Exception: Traceback (most recent call last): File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 303, in start res = self.get_data(method, lexer, args, kwargs, text) File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 171, in get_data res = self.highlight_text(text, lexer, formatter_name, args, _convert_keys(opts)) File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 122, in highlight_text lexer = self.return_lexer(lexer, args, kwargs, code) File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 79, in return_lexer return lexers.get_lexer_by_name(lexer, **inputs) File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/vendor/pygments-main/pygments/lexers/__init__.py", line 95, in get_lexer_by_name for cls in find_plugin_lexers(): File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/vendor/pygments-main/pygments/plugin.py", line 53, in find_plugin_lexers yield entrypoint.load() File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2323, in load self.require(*args, **kwargs) File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2346, in require items = working_set.resolve(reqs, env, installer, extras=self.extras) File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 778, in resolve raise DistributionNotFound(req, requirers) DistributionNotFound: The 'pygments' distribution was not found and is required by the application in _posts/2019-03-05-transparent-hierarchical-storage-management-with-apache-kudu-and-impala.md
jekyll 2.5.3 | Error: Traceback (most recent call last):
File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 303, in start
res = self.get_data(method, lexer, args, kwargs, text)
File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 171, in get_data
res = self.highlight_text(text, lexer, formatter_name, args, _convert_keys(opts))
File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 122, in highlight_text
lexer = self.return_lexer(lexer, args, kwargs, code)
File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/lib/pygments/mentos.py", line 79, in return_lexer
return lexers.get_lexer_by_name(lexer, **inputs)
File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/vendor/pygments-main/pygments/lexers/__init__.py", line 95, in get_lexer_by_name
for cls in find_plugin_lexers():
File "/home/mpercy/src/kudu-site/.gem/ruby/2.5.0/gems/pygments.rb-0.6.3/vendor/pygments-main/pygments/plugin.py", line 53, in find_plugin_lexers
yield entrypoint.load()
File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2323, in load
self.require(*args, **kwargs)
File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2346, in require
items = working_set.resolve(reqs, env, installer, extras=self.extras)
File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 778, in resolve
raise DistributionNotFound(req, requirers)
DistributionNotFound: The 'pygments' distribution was not found and is required by the application
After changing {% highlight shell %} to {% highlight bash %}, the site
is generated without errors.
Change-Id: I4beafc5c5e272f304a3cc9a44282e80715bea3e5
Reviewed-on: http://gerrit.cloudera.org:8080/12667
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M _posts/2019-03-05-transparent-hierarchical-storage-management-with-apache-kudu-and-impala.md
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: I4beafc5c5e272f304a3cc9a44282e80715bea3e5
Gerrit-Change-Number: 12667
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR](gh-pages) Use bash instead of shell highlighting in blog post
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12667 )
Change subject: Use bash instead of shell highlighting in blog post
......................................................................
Patch Set 1:
FYI here is a render: http://mpercy.github.io/kudu/2019/03/05/transparent-hierarchical-storage-management-with-apache-kudu-and-impala.html
The ${...} in the SQL is highlighted a little funnily, but I'm not sure there's much we can do.
--
To view, visit http://gerrit.cloudera.org:8080/12667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4beafc5c5e272f304a3cc9a44282e80715bea3e5
Gerrit-Change-Number: 12667
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 05 Mar 2019 23:48:03 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) Use bash instead of shell highlighting in blog post
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12667 )
Change subject: Use bash instead of shell highlighting in blog post
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4beafc5c5e272f304a3cc9a44282e80715bea3e5
Gerrit-Change-Number: 12667
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Tue, 05 Mar 2019 23:45:52 +0000
Gerrit-HasComments: No