You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2016/01/07 17:03:35 UTC
[GitHub] incubator-brooklyn pull request: In skipInstall include also pre-i...
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1132
In skipInstall include also pre-install-command
copy-pre-install-resources, pre-install, pre-install-command
It makes much more sense to include those in the skip install family.
These phases are barely used but still I think it simplifies the lifecycle if it is like this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn redefine_skip_install
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1132
----
commit 8d1ff758dd9f2f02c30c40849a433e56a03a21b9
Author: Valentin Aitken <va...@cloudsoftcorp.com>
Date: 2016-01-07T16:00:53Z
In skipInstall include also :
copy-pre-install-resources, pre-install, pre-install-command
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: In skipInstall include also pre-i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: In skipInstall include also pre-i...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1132#issuecomment-172400790
@bostko If I remember right, I wanted the option to run some commands even if we were skipping the normal entity startup. However, you're probably right that it's barely used, but I'd like to be sure nothing uses this before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: In skipInstall include also pre-i...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1132#issuecomment-172870461
AFAIK very little uses pre-install, and none of those should be surprised if it's skipped on "skipInstall". will go ahead and merge. @grkvlt @bostko if you discover anything give a shout. maybe it's worth a call out in the release notes? (again i tend to think not necessary but no objections.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---