[jira] Updated: (WICKET-3393) Remove ApplicationContextHolder from SpringComponentInjector

["Attila Király (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Attila Király updated WICKET-3393:
----------------------------------

    Attachment: WICKET-3393-fix.patch

Attaching suggested patch. Test pass with it.
Patch contains a trivial change to the unrelated o.a.w.protocol.http.mock.MockServletContext class too. As wicket 1.5 needs servlet 2.5 the mock context should report minor version 5 instead of 3. I didn't want to open a different issue for this.

> Remove ApplicationContextHolder from SpringComponentInjector
> ------------------------------------------------------------
>
>                 Key: WICKET-3393
>                 URL: https://issues.apache.org/jira/browse/WICKET-3393
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-spring
>    Affects Versions: 1.5-RC1
>            Reporter: Attila Király
>            Priority: Minor
>         Attachments: WICKET-3393-fix.patch
>
>
> ApplicationContextHolder is a private inner class in o.a.w.spring.injection.annot.SpringComponentInjector class. It was designed to be used as a workaround to store the non serializable spring ApplicationContext in a serializable wrapper as Application metadata. But Application metadata does not need to be Serializable anymore so this boxing is not needed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.