You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/09/26 07:35:44 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #34620: Use ExitStack to manage mutation of secrets_backend_list in dag.test

uranusjr commented on code in PR #34620:
URL: https://github.com/apache/airflow/pull/34620#discussion_r1336759573


##########
airflow/exceptions.py:
##########
@@ -424,3 +424,11 @@ def __str__(self):
             "Error deserializing result. Note that result deserialization "
             "is not supported across major Python versions. Cause: " + str(self.__cause__)
         )
+
+
+class StopDagTest(AirflowException):

Review Comment:
   I don’t think there’s anything to gain inheriting from AirflowException. It might be better to just make this inherit from Exception and put it in `dag.py` instead.



##########
airflow/exceptions.py:
##########
@@ -424,3 +424,11 @@ def __str__(self):
             "Error deserializing result. Note that result deserialization "
             "is not supported across major Python versions. Cause: " + str(self.__cause__)
         )
+
+
+class StopDagTest(AirflowException):

Review Comment:
   I don’t think there’s anything to gain inheriting from AirflowException. It might be better to just make this inherit from Exception and put it in `dag.py` instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org