You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by jw...@apache.org on 2011/03/02 21:29:31 UTC

svn commit: r1076366 - /myfaces/trinidad/trunk/src/site/xdoc/devguide/skinning.xml

Author: jwaldman
Date: Wed Mar  2 20:29:30 2011
New Revision: 1076366

URL: http://svn.apache.org/viewvc?rev=1076366&view=rev
Log:
TRINIDAD-1866 -tr-inhibit does not work with icon skinning selectors
added this to the documentation.

Modified:
    myfaces/trinidad/trunk/src/site/xdoc/devguide/skinning.xml

Modified: myfaces/trinidad/trunk/src/site/xdoc/devguide/skinning.xml
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/src/site/xdoc/devguide/skinning.xml?rev=1076366&r1=1076365&r2=1076366&view=diff
==============================================================================
--- myfaces/trinidad/trunk/src/site/xdoc/devguide/skinning.xml (original)
+++ myfaces/trinidad/trunk/src/site/xdoc/devguide/skinning.xml Wed Mar  2 20:29:30 2011
@@ -660,10 +660,15 @@ so the medium panelBox's body will be pi
                 content: '?';
               }            
             </source>
-              <P>There are some limitations with skinning icons that do not exist when skinning styles. 
-              You cannot use the skin properties like -tr-rule-ref and -tr-inhibit when skinning icons 
-              though you can when skinning style selectors. These limitations should some day be 
-              fixed and this documentation will be updated then.</P> 
+              <P>Until recently there were limitations with skinning icons that -tr-rule-ref and -tr-inhibit were not supported. 
+              Further, the skin properties were not inherited from base skin for icon selectors. 
+              We fixed these limitations to make the icon selector behavior consistent with general skinning style selectors. 
+              Now that we inherit the skin properties for icons, if there were 'content' and other properties like 'width' and 'height' set, 
+              and you override just the 'content' property in your custom skin, you would inherit the 'width' and 'height' 
+              from the base skin. While this is a change in behavior, it is a change in right direction. 
+              If this behavior is not desirable, skinners can use -tr-inhibit to inhibit some properties or 
+              'tr-inhibit: all' to inhibit all properties before overriding the 'content' property.
+              </P> 
         </subsection>
         <a name="urls"></a>
         <subsection name="Specifying urls">