You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ke...@apache.org on 2016/04/26 22:27:11 UTC

[1/2] incubator-beam git commit: Output InProcessGroupByKeyOnly elements in the Global Window

Repository: incubator-beam
Updated Branches:
  refs/heads/master 7dc1a4047 -> 9746f0d1d


Output InProcessGroupByKeyOnly elements in the Global Window

This ensures that the values are not dropped if they are exploded (for
example, in the Watermark Manager).


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/a9e0f017
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/a9e0f017
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/a9e0f017

Branch: refs/heads/master
Commit: a9e0f01748e00124d4851106cfa85da386f4531e
Parents: 7dc1a40
Author: Thomas Groh <tg...@google.com>
Authored: Tue Apr 26 11:46:26 2016 -0700
Committer: Thomas Groh <tg...@google.com>
Committed: Tue Apr 26 11:46:26 2016 -0700

----------------------------------------------------------------------
 .../beam/sdk/runners/inprocess/GroupByKeyEvaluatorFactory.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/a9e0f017/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/inprocess/GroupByKeyEvaluatorFactory.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/inprocess/GroupByKeyEvaluatorFactory.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/inprocess/GroupByKeyEvaluatorFactory.java
index ec0af8d..4cec841 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/inprocess/GroupByKeyEvaluatorFactory.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/inprocess/GroupByKeyEvaluatorFactory.java
@@ -149,7 +149,7 @@ class GroupByKeyEvaluatorFactory implements TransformEvaluatorFactory {
             KeyedWorkItems.elementsWorkItem(key, groupedEntry.getValue());
         UncommittedBundle<KeyedWorkItem<K, V>> bundle =
             evaluationContext.createKeyedBundle(inputBundle, key, application.getOutput());
-        bundle.add(WindowedValue.valueInEmptyWindows(groupedKv));
+        bundle.add(WindowedValue.valueInGlobalWindow(groupedKv));
         resultBuilder.addOutput(bundle);
       }
       return resultBuilder.build();


[2/2] incubator-beam git commit: This closes #242

Posted by ke...@apache.org.
This closes #242


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/9746f0d1
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/9746f0d1
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/9746f0d1

Branch: refs/heads/master
Commit: 9746f0d1d78dd7ac9c37d414347eb95b528b4d47
Parents: 7dc1a40 a9e0f01
Author: Kenneth Knowles <kl...@google.com>
Authored: Tue Apr 26 13:26:49 2016 -0700
Committer: Kenneth Knowles <kl...@google.com>
Committed: Tue Apr 26 13:26:49 2016 -0700

----------------------------------------------------------------------
 .../beam/sdk/runners/inprocess/GroupByKeyEvaluatorFactory.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------