You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Sijie Guo <gu...@gmail.com> on 2018/10/10 04:25:50 UTC
integration tests
Hi all,
Currently Apache Jenkins has been back to normal for a few days and most of
the recent PRs have been passing all jenkins check.
Committers, please only merge PRs when it passes all CI checks and not
merge changes that can be breaking master. Otherwise it is really hard to
get CI back to normal again.
- Sijie
Re: integration tests
Posted by Sanjeev Kulkarni <sa...@gmail.com>.
+1 on making it mandatory.
On Tue, Oct 9, 2018 at 9:36 PM Matteo Merli <mm...@apache.org> wrote:
> Should we ask infra to make the integration tests check to be mandatory?
>
> On Tue, Oct 9, 2018 at 9:26 PM Sijie Guo <gu...@gmail.com> wrote:
>
> > Hi all,
> >
> > Currently Apache Jenkins has been back to normal for a few days and most
> of
> > the recent PRs have been passing all jenkins check.
> >
> > Committers, please only merge PRs when it passes all CI checks and not
> > merge changes that can be breaking master. Otherwise it is really hard to
> > get CI back to normal again.
> >
> > - Sijie
> >
> --
> Matteo Merli
> <mm...@apache.org>
>
Re: integration tests
Posted by Matteo Merli <mm...@apache.org>.
Integration tests are now required to be able to merge PRs.
--
Matteo Merli
<mm...@apache.org>
On Wed, Oct 10, 2018 at 2:08 PM Matteo Merli <mm...@apache.org> wrote:
> Created jira: https://issues.apache.org/jira/browse/INFRA-17129
>
> On Wed, Oct 10, 2018 at 7:23 AM Ivan Kelly <iv...@apache.org> wrote:
>
>> +1
>>
>> On Wed, Oct 10, 2018 at 6:51 AM, Sijie Guo <gu...@gmail.com> wrote:
>> > +1 for making it mandatory.
>> >
>> > - Sijie
>> >
>> > On Tue, Oct 9, 2018 at 9:36 PM Matteo Merli <mm...@apache.org> wrote:
>> >
>> >> Should we ask infra to make the integration tests check to be
>> mandatory?
>> >>
>> >> On Tue, Oct 9, 2018 at 9:26 PM Sijie Guo <gu...@gmail.com> wrote:
>> >>
>> >> > Hi all,
>> >> >
>> >> > Currently Apache Jenkins has been back to normal for a few days and
>> most
>> >> of
>> >> > the recent PRs have been passing all jenkins check.
>> >> >
>> >> > Committers, please only merge PRs when it passes all CI checks and
>> not
>> >> > merge changes that can be breaking master. Otherwise it is really
>> hard to
>> >> > get CI back to normal again.
>> >> >
>> >> > - Sijie
>> >> >
>> >> --
>> >> Matteo Merli
>> >> <mm...@apache.org>
>> >>
>>
> --
> Matteo Merli
> <mm...@apache.org>
>
Re: integration tests
Posted by Matteo Merli <mm...@apache.org>.
Created jira: https://issues.apache.org/jira/browse/INFRA-17129
On Wed, Oct 10, 2018 at 7:23 AM Ivan Kelly <iv...@apache.org> wrote:
> +1
>
> On Wed, Oct 10, 2018 at 6:51 AM, Sijie Guo <gu...@gmail.com> wrote:
> > +1 for making it mandatory.
> >
> > - Sijie
> >
> > On Tue, Oct 9, 2018 at 9:36 PM Matteo Merli <mm...@apache.org> wrote:
> >
> >> Should we ask infra to make the integration tests check to be mandatory?
> >>
> >> On Tue, Oct 9, 2018 at 9:26 PM Sijie Guo <gu...@gmail.com> wrote:
> >>
> >> > Hi all,
> >> >
> >> > Currently Apache Jenkins has been back to normal for a few days and
> most
> >> of
> >> > the recent PRs have been passing all jenkins check.
> >> >
> >> > Committers, please only merge PRs when it passes all CI checks and not
> >> > merge changes that can be breaking master. Otherwise it is really
> hard to
> >> > get CI back to normal again.
> >> >
> >> > - Sijie
> >> >
> >> --
> >> Matteo Merli
> >> <mm...@apache.org>
> >>
>
--
Matteo Merli
<mm...@apache.org>
Re: integration tests
Posted by Ivan Kelly <iv...@apache.org>.
+1
On Wed, Oct 10, 2018 at 6:51 AM, Sijie Guo <gu...@gmail.com> wrote:
> +1 for making it mandatory.
>
> - Sijie
>
> On Tue, Oct 9, 2018 at 9:36 PM Matteo Merli <mm...@apache.org> wrote:
>
>> Should we ask infra to make the integration tests check to be mandatory?
>>
>> On Tue, Oct 9, 2018 at 9:26 PM Sijie Guo <gu...@gmail.com> wrote:
>>
>> > Hi all,
>> >
>> > Currently Apache Jenkins has been back to normal for a few days and most
>> of
>> > the recent PRs have been passing all jenkins check.
>> >
>> > Committers, please only merge PRs when it passes all CI checks and not
>> > merge changes that can be breaking master. Otherwise it is really hard to
>> > get CI back to normal again.
>> >
>> > - Sijie
>> >
>> --
>> Matteo Merli
>> <mm...@apache.org>
>>
Re: integration tests
Posted by Sijie Guo <gu...@gmail.com>.
+1 for making it mandatory.
- Sijie
On Tue, Oct 9, 2018 at 9:36 PM Matteo Merli <mm...@apache.org> wrote:
> Should we ask infra to make the integration tests check to be mandatory?
>
> On Tue, Oct 9, 2018 at 9:26 PM Sijie Guo <gu...@gmail.com> wrote:
>
> > Hi all,
> >
> > Currently Apache Jenkins has been back to normal for a few days and most
> of
> > the recent PRs have been passing all jenkins check.
> >
> > Committers, please only merge PRs when it passes all CI checks and not
> > merge changes that can be breaking master. Otherwise it is really hard to
> > get CI back to normal again.
> >
> > - Sijie
> >
> --
> Matteo Merli
> <mm...@apache.org>
>
Re: integration tests
Posted by Matteo Merli <mm...@apache.org>.
Should we ask infra to make the integration tests check to be mandatory?
On Tue, Oct 9, 2018 at 9:26 PM Sijie Guo <gu...@gmail.com> wrote:
> Hi all,
>
> Currently Apache Jenkins has been back to normal for a few days and most of
> the recent PRs have been passing all jenkins check.
>
> Committers, please only merge PRs when it passes all CI checks and not
> merge changes that can be breaking master. Otherwise it is really hard to
> get CI back to normal again.
>
> - Sijie
>
--
Matteo Merli
<mm...@apache.org>