You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by CodingCat <gi...@git.apache.org> on 2014/09/07 15:42:47 UTC
[GitHub] spark pull request: [SPARK-1191][RESUBMIT]Missing document of some...
GitHub user CodingCat opened a pull request:
https://github.com/apache/spark/pull/2312
[SPARK-1191][RESUBMIT]Missing document of some parameters in Spark Core
It's a resubmission of https://github.com/apache/spark/pull/85 according to @mateiz 's suggestion
----
Hi, @mateiz and @pwendell
I found that nearly all parameters in constructing actor system (AkkaUtil) are not documented...
IIRC, there was a PR which proposes that we should leave space for the user to configure the Akka system, is that still valid?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/CodingCat/spark configuration
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2312.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2312
----
commit 5e6aea2dc4495c1a28c81778e6a4a4c846c53575
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T02:53:39Z
spark.worker.timeout
commit e129d6a442581ab1a61d16f60ad5fb31799c6f2f
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T03:04:43Z
spark.deploy.retainedApplications
commit db2e4037f085a41d6ea115d5426325df857de287
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T03:28:29Z
spark.dead.worker.persistence
commit bd928761d1c2e00078cfaf7b2b22731930e411b1
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T03:36:57Z
spark.deploy.recoveryDirectory
commit 81ba0190b3698d40119d57b96ad93a8ce0c55f20
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T03:44:21Z
spark.deploy.spreadOut
commit c5660033720c1442dbdfabb4a527fe685829fff3
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T12:38:29Z
spark.master.ui.port
commit be347c7721f3893b53f1c3a448dbca5ba446490f
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T12:44:32Z
remove some duplicate parameters
commit 6bec304c19c58646a97f4d96a1cb68ef9289c139
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T12:53:03Z
spark.shuffle.io.*
commit 9b35651cfe570a1e5fae7fed06d66f9ea5d7b594
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T13:03:27Z
spark.shuffle.io.netty.* -2
commit 68d209f1789f5b69cbe465ad11caa2c1070fdb82
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T13:15:24Z
spark.eventLog.overwrite
commit bf9282f1759bf288b235fd2cccb00bfc6b2ea0e1
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T13:23:16Z
spark.scheduler.executorTaskBlacklistTime
commit 6fb02f034e688fd04e0586e2aaff964e61897b64
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T13:26:05Z
spark.logging.exceptionPrintInterval
commit 94226968f079b82181ef0a7669d04bd2171c0056
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T13:32:59Z
spark.shuffle.safetyFraction
commit a4aa3dec045fd9d3c7902340e73a92f88ba7a820
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T13:39:29Z
spark.storage.safetyFraction
commit 4ed3a8191c52800b046c131ab1f35b84b2cdc87f
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T13:45:25Z
spark.storage.blockManagerSlaveTimeoutMs
commit 9f4e2cd202139b8bfe88f814d61436d3b88bffc8
Author: Nan Zhu <na...@nans-macbook-pro.local>
Date: 2014-09-07T13:49:31Z
spark.storage.blockManagerTimeoutIntervalMs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1192][RESUBMIT]Missing document of some...
Posted by CodingCat <gi...@git.apache.org>.
Github user CodingCat closed the pull request at:
https://github.com/apache/spark/pull/2312
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1191][RESUBMIT]Missing document of some...
Posted by CodingCat <gi...@git.apache.org>.
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/2312#issuecomment-54747100
ignore the first 6 parameters...they are duplicate with the ones in spark-standalone.md...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1191][RESUBMIT]Missing document of some...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2312#issuecomment-54747132
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19947/consoleFull) for PR 2312 at commit [`9f4e2cd`](https://github.com/apache/spark/commit/9f4e2cd202139b8bfe88f814d61436d3b88bffc8).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1192][RESUBMIT]Missing document of some...
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2312#issuecomment-74011120
@CodingCat This PR has gone stale. Do you want to update it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1191][RESUBMIT]Missing document of some...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2312#issuecomment-54750569
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19950/consoleFull) for PR 2312 at commit [`1784b47`](https://github.com/apache/spark/commit/1784b477dd19a2f2957b480a75213e6f242bf2e9).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1192][RESUBMIT]Missing document of some...
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2312#issuecomment-74153398
Okie doke. Sounds good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1192][RESUBMIT]Missing document of some...
Posted by CodingCat <gi...@git.apache.org>.
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/2312#issuecomment-74146975
@nchammas this has been a long process (since my first submit in https://github.com/apache/spark/pull/85) , since most of the parameters are not frequently involved in the daily usage, I will close this one
Maybe we can update the doc for those missing parameters once we find some of them are useful
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1191][RESUBMIT]Missing document of some...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2312#issuecomment-54752416
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19950/consoleFull) for PR 2312 at commit [`1784b47`](https://github.com/apache/spark/commit/1784b477dd19a2f2957b480a75213e6f242bf2e9).
* This patch **fails** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1191][RESUBMIT]Missing document of some...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2312#issuecomment-54748697
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19947/consoleFull) for PR 2312 at commit [`9f4e2cd`](https://github.com/apache/spark/commit/9f4e2cd202139b8bfe88f814d61436d3b88bffc8).
* This patch **fails** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org