You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2017/12/11 06:07:54 UTC

[GitHub] carbondata pull request #1639: [CARBONDATA-1881] Insert overwrite value for ...

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/1639

    [CARBONDATA-1881] Insert overwrite value for pre-aggregate load was incorrect

    Analysis: while loading the value for insert overwrite was set to false.
    
    Solution: Consider the value of insert overwrite set for maintable for pre-aggregate table loading.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [X] Any interfaces changed?
     no
     - [X] Any backward compatibility impacted?
     no
     - [X] Document update required?
    no
     - [X] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata insert_overwrite_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1639.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1639
    
----
commit dc077a7b611dad09de2ea8bbb3efcfd8efba6348
Author: kunal642 <ku...@gmail.com>
Date:   2017-12-11T05:50:43Z

    insert overwrite value for pre-aggregate load was incorrect

----


---

[GitHub] carbondata issue #1639: [CARBONDATA-1881] Insert overwrite value for pre-agg...

Posted by kunal642 <gi...@git.apache.org>.

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/1639
  
    retest sdv please


---

[GitHub] carbondata issue #1639: [CARBONDATA-1881] Insert overwrite value for pre-agg...

Posted by kunal642 <gi...@git.apache.org>.

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/1639
  
    Retest this please


---

[GitHub] carbondata issue #1639: [CARBONDATA-1881] Insert overwrite value for pre-agg...

Posted by kumarvishal09 <gi...@git.apache.org>.

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/1639
  
    LGTM


---

[GitHub] carbondata issue #1639: [CARBONDATA-1881] Insert overwrite value for pre-agg...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1639
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1862/



---

[GitHub] carbondata issue #1639: [CARBONDATA-1881] Insert overwrite value for pre-agg...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1639
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2205/



---

[GitHub] carbondata issue #1639: [CARBONDATA-1881] Insert overwrite value for pre-agg...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1639
  
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/633/



---

[GitHub] carbondata issue #1639: [CARBONDATA-1881] Insert overwrite value for pre-agg...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1639
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1860/



---

[GitHub] carbondata issue #1639: [CARBONDATA-1881] Insert overwrite value for pre-agg...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1639
  
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/631/



---