You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/20 03:12:54 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #11501: Dataflow - add waiting for successful job cancel

mik-laj commented on a change in pull request #11501:
URL: https://github.com/apache/airflow/pull/11501#discussion_r508182849



##########
File path: airflow/providers/google/cloud/hooks/dataflow.py
##########
@@ -331,6 +361,12 @@ def cancel(self) -> None:
                     )
                 )
             batch.execute()
+            if self._cancel_timeout and isinstance(self._cancel_timeout, int):

Review comment:
       What other type of field do you envision here? The method signature uses ʻint`. Did you want to support `Optional[Int]` here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org