You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2023/04/25 13:25:02 UTC

[commons-numbers] 02/07: PMD fix: Remove unused variable initializer

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 35ed711accea80ff3dbdbb4546251c1d96cc6edb
Author: aherbert <ah...@apache.org>
AuthorDate: Tue Apr 25 13:57:37 2023 +0100

    PMD fix: Remove unused variable initializer
---
 .../main/java/org/apache/commons/numbers/fraction/BigFraction.java    | 4 ++--
 .../src/main/java/org/apache/commons/numbers/fraction/Fraction.java   | 4 ++--
 .../src/main/java/org/apache/commons/numbers/gamma/BoostErf.java      | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
index 43ecf80b..de664e6d 100644
--- a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
+++ b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
@@ -175,8 +175,8 @@ public final class BigFraction
         long p1 = a0;
         long q1 = 1;
 
-        long p2 = 0;
-        long q2 = 1;
+        long p2;
+        long q2;
 
         int n = 0;
         boolean stop = false;
diff --git a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
index 2afe7389..3f3500e8 100644
--- a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
+++ b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
@@ -198,8 +198,8 @@ public final class Fraction
         long p1 = a0;
         long q1 = 1;
 
-        long p2 = 0;
-        long q2 = 1;
+        long p2;
+        long q2;
 
         int n = 0;
         boolean stop = false;
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/BoostErf.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/BoostErf.java
index e8d3790f..b95e3526 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/BoostErf.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/BoostErf.java
@@ -511,7 +511,7 @@ final class BoostErf {
      * @return the inverse
      */
     private static double erfInvImp(double p, double q) {
-        double result = 0;
+        double result;
 
         if (p <= 0.5) {
             //