You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/08/01 21:37:16 UTC
Re: Review Request 24128: Add 'max_num_executors' flag for use with network
isolation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/
-----------------------------------------------------------
(Updated Aug. 1, 2014, 12:37 p.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Changes
-------
added test
Bugs: MESOS-1654
https://issues.apache.org/jira/browse/MESOS-1654
Repository: mesos-git
Description
-------
when network isolation is enabled, we should keep track of how many executors have launched on a given host to avoid sending offers for those that have hit the container limit.
this is a short-term fix for the issue to enable broader testing of network monitoring and isolation.
Diffs (updated)
-----
src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
src/master/master.cpp 77f2536c36df9a0a1f6021bd4732baa3ab424459
src/tests/master_tests.cpp 5a1cf7f1f7a4864f516825cc14504c870b60055e
Diff: https://reviews.apache.org/r/24128/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 24128: Add 'max_num_executors' flag for use with network
isolation
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Aug. 1, 2014, 4:30 p.m., Jie Yu wrote:
> > src/master/master.cpp, line 3434
> > <https://reviews.apache.org/r/24128/diff/4/?file=648800#file648800line3434>
> >
> > Could you please add an optional filer for 'resourcesRecovered' (similar to that in 'resourcesUnused'), and use a default filter here.
I'm not sure how necessary this is, and I'm aware of scope creep here. I've made the change but I think this would be better split out. Also added a TODO to merge the similar resources* methods on the Allocator.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/#review49400
-----------------------------------------------------------
On Aug. 1, 2014, 5:03 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24128/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2014, 5:03 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1654
> https://issues.apache.org/jira/browse/MESOS-1654
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> when network isolation is enabled, we should keep track of how many executors have launched on a given host to avoid sending offers for those that have hit the container limit.
>
> this is a short-term fix for the issue to enable broader testing of network monitoring and isolation.
>
>
> Diffs
> -----
>
> docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
> src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
> src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
> src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
> src/master/master.cpp 77f2536c36df9a0a1f6021bd4732baa3ab424459
> src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
> src/tests/master_tests.cpp 5a1cf7f1f7a4864f516825cc14504c870b60055e
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/slave_recovery_tests.cpp 0b17a8afb6aa66ab19f6fcd90906fb4eb2c39f05
>
> Diff: https://reviews.apache.org/r/24128/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24128: Add 'max_num_executors' flag for use with network
isolation
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/#review49400
-----------------------------------------------------------
We probably wanna go with this patch for 0.20.0. See MESOS-1466 for details. However, for 0.20.0, besides this patch, I'll kill private_resources and add ephemeral ports to 'resources', but not sending it to the master.
src/master/flags.hpp
<https://reviews.apache.org/r/24128/#comment86460>
s/int/size_t/
src/master/master.cpp
<https://reviews.apache.org/r/24128/#comment86461>
Link the ticket: MESOS-1654 in the TODO.
Also, would you please explain briefly why we need this flag with the existing code.
src/master/master.cpp
<https://reviews.apache.org/r/24128/#comment86462>
Could you please add an optional filer for 'resourcesRecovered' (similar to that in 'resourcesUnused'), and use a default filter here.
- Jie Yu
On Aug. 1, 2014, 7:37 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24128/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2014, 7:37 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1654
> https://issues.apache.org/jira/browse/MESOS-1654
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> when network isolation is enabled, we should keep track of how many executors have launched on a given host to avoid sending offers for those that have hit the container limit.
>
> this is a short-term fix for the issue to enable broader testing of network monitoring and isolation.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
> src/master/master.cpp 77f2536c36df9a0a1f6021bd4732baa3ab424459
> src/tests/master_tests.cpp 5a1cf7f1f7a4864f516825cc14504c870b60055e
>
> Diff: https://reviews.apache.org/r/24128/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24128: Add 'max_num_executors' flag for use with network
isolation
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/#review49420
-----------------------------------------------------------
Bad patch!
Reviews applied: [24128]
Failed command: ./support/mesos-style.py
Error:
Checking 494 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
src/master/hierarchical_allocator_process.hpp:660: Lines should be <= 80 characters long [whitespace/line_length] [2]
src/master/hierarchical_allocator_process.hpp:667: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
Total errors found: 2
- Mesos ReviewBot
On Aug. 2, 2014, 12:03 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24128/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2014, 12:03 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1654
> https://issues.apache.org/jira/browse/MESOS-1654
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> when network isolation is enabled, we should keep track of how many executors have launched on a given host to avoid sending offers for those that have hit the container limit.
>
> this is a short-term fix for the issue to enable broader testing of network monitoring and isolation.
>
>
> Diffs
> -----
>
> docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
> src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
> src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
> src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
> src/master/master.cpp 77f2536c36df9a0a1f6021bd4732baa3ab424459
> src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
> src/tests/master_tests.cpp 5a1cf7f1f7a4864f516825cc14504c870b60055e
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/slave_recovery_tests.cpp 0b17a8afb6aa66ab19f6fcd90906fb4eb2c39f05
>
> Diff: https://reviews.apache.org/r/24128/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24128: Add 'max_num_executors' flag for use with network
isolation
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/#review49643
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 5, 2014, 6:48 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24128/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 6:48 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1666
> https://issues.apache.org/jira/browse/MESOS-1666
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> when network isolation is enabled, we should keep track of how many executors have launched on a given host to avoid sending offers for those that have hit the container limit.
>
> this is a short-term fix for the issue to enable broader testing of network monitoring and isolation.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
> src/master/master.cpp 77f2536c36df9a0a1f6021bd4732baa3ab424459
> src/tests/master_tests.cpp 5a1cf7f1f7a4864f516825cc14504c870b60055e
>
> Diff: https://reviews.apache.org/r/24128/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24128: Add 'max_num_executors' flag for use with network
isolation
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 11:48 a.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Changes
-------
just the master changes. will followup with resourcesRecovered changes to add Filters.
Bugs: MESOS-1666
https://issues.apache.org/jira/browse/MESOS-1666
Repository: mesos-git
Description
-------
when network isolation is enabled, we should keep track of how many executors have launched on a given host to avoid sending offers for those that have hit the container limit.
this is a short-term fix for the issue to enable broader testing of network monitoring and isolation.
Diffs (updated)
-----
src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
src/master/master.cpp 77f2536c36df9a0a1f6021bd4732baa3ab424459
src/tests/master_tests.cpp 5a1cf7f1f7a4864f516825cc14504c870b60055e
Diff: https://reviews.apache.org/r/24128/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 24128: Add 'max_num_executors' flag for use with network
isolation
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Aug. 5, 2014, 10:50 a.m., Jie Yu wrote:
> > src/master/allocator.hpp, line 121
> > <https://reviews.apache.org/r/24128/diff/6/?file=650513#file650513line121>
> >
> > Seems that having a default in a virtual function is dangerous. Refer to this thread:
> > http://stackoverflow.com/questions/3533589/can-virtual-functions-have-default-parameters
> >
> > I prefer removing the default (just like we did for resourcesUnused). I understand that it means a lot of changes to the tests and code.
> >
> >
how do you feel about splitting this change: one to add the flag with the logic in master, and one to add the filter to resourcesRecovered?
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/#review49620
-----------------------------------------------------------
On Aug. 4, 2014, 2:43 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24128/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 2:43 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1666
> https://issues.apache.org/jira/browse/MESOS-1666
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> when network isolation is enabled, we should keep track of how many executors have launched on a given host to avoid sending offers for those that have hit the container limit.
>
> this is a short-term fix for the issue to enable broader testing of network monitoring and isolation.
>
>
> Diffs
> -----
>
> docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
> src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
> src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
> src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
> src/master/master.cpp 77f2536c36df9a0a1f6021bd4732baa3ab424459
> src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
> src/tests/master_tests.cpp 5a1cf7f1f7a4864f516825cc14504c870b60055e
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/slave_recovery_tests.cpp 0b17a8afb6aa66ab19f6fcd90906fb4eb2c39f05
>
> Diff: https://reviews.apache.org/r/24128/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24128: Add 'max_num_executors' flag for use with network
isolation
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 5, 2014, 5:50 p.m., Jie Yu wrote:
> > src/master/allocator.hpp, line 121
> > <https://reviews.apache.org/r/24128/diff/6/?file=650513#file650513line121>
> >
> > Seems that having a default in a virtual function is dangerous. Refer to this thread:
> > http://stackoverflow.com/questions/3533589/can-virtual-functions-have-default-parameters
> >
> > I prefer removing the default (just like we did for resourcesUnused). I understand that it means a lot of changes to the tests and code.
> >
> >
>
> Dominic Hamon wrote:
> how do you feel about splitting this change: one to add the flag with the logic in master, and one to add the filter to resourcesRecovered?
Sounds good to me!
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/#review49620
-----------------------------------------------------------
On Aug. 4, 2014, 9:43 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24128/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 9:43 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1666
> https://issues.apache.org/jira/browse/MESOS-1666
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> when network isolation is enabled, we should keep track of how many executors have launched on a given host to avoid sending offers for those that have hit the container limit.
>
> this is a short-term fix for the issue to enable broader testing of network monitoring and isolation.
>
>
> Diffs
> -----
>
> docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
> src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
> src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
> src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
> src/master/master.cpp 77f2536c36df9a0a1f6021bd4732baa3ab424459
> src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
> src/tests/master_tests.cpp 5a1cf7f1f7a4864f516825cc14504c870b60055e
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/slave_recovery_tests.cpp 0b17a8afb6aa66ab19f6fcd90906fb4eb2c39f05
>
> Diff: https://reviews.apache.org/r/24128/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24128: Add 'max_num_executors' flag for use with network
isolation
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/#review49620
-----------------------------------------------------------
src/master/allocator.hpp
<https://reviews.apache.org/r/24128/#comment86845>
Seems that having a default in a virtual function is dangerous. Refer to this thread:
http://stackoverflow.com/questions/3533589/can-virtual-functions-have-default-parameters
I prefer removing the default (just like we did for resourcesUnused). I understand that it means a lot of changes to the tests and code.
src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/24128/#comment86856>
What if seconds == Duration::zero()? Probably you should just copy the logic from above.
src/master/master.cpp
<https://reviews.apache.org/r/24128/#comment86857>
Remove the tailing period.
- Jie Yu
On Aug. 4, 2014, 9:43 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24128/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 9:43 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1666
> https://issues.apache.org/jira/browse/MESOS-1666
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> when network isolation is enabled, we should keep track of how many executors have launched on a given host to avoid sending offers for those that have hit the container limit.
>
> this is a short-term fix for the issue to enable broader testing of network monitoring and isolation.
>
>
> Diffs
> -----
>
> docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
> src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
> src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
> src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
> src/master/master.cpp 77f2536c36df9a0a1f6021bd4732baa3ab424459
> src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
> src/tests/master_tests.cpp 5a1cf7f1f7a4864f516825cc14504c870b60055e
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/slave_recovery_tests.cpp 0b17a8afb6aa66ab19f6fcd90906fb4eb2c39f05
>
> Diff: https://reviews.apache.org/r/24128/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24128: Add 'max_num_executors' flag for use with network
isolation
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 2:43 p.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Bugs: MESOS-1666
https://issues.apache.org/jira/browse/MESOS-1666
Repository: mesos-git
Description
-------
when network isolation is enabled, we should keep track of how many executors have launched on a given host to avoid sending offers for those that have hit the container limit.
this is a short-term fix for the issue to enable broader testing of network monitoring and isolation.
Diffs
-----
docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
src/master/master.cpp 77f2536c36df9a0a1f6021bd4732baa3ab424459
src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
src/tests/master_tests.cpp 5a1cf7f1f7a4864f516825cc14504c870b60055e
src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
src/tests/slave_recovery_tests.cpp 0b17a8afb6aa66ab19f6fcd90906fb4eb2c39f05
Diff: https://reviews.apache.org/r/24128/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 24128: Add 'max_num_executors' flag for use with network
isolation
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 9:58 a.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Changes
-------
fix format issues
Bugs: MESOS-1654
https://issues.apache.org/jira/browse/MESOS-1654
Repository: mesos-git
Description
-------
when network isolation is enabled, we should keep track of how many executors have launched on a given host to avoid sending offers for those that have hit the container limit.
this is a short-term fix for the issue to enable broader testing of network monitoring and isolation.
Diffs (updated)
-----
docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
src/master/master.cpp 77f2536c36df9a0a1f6021bd4732baa3ab424459
src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
src/tests/master_tests.cpp 5a1cf7f1f7a4864f516825cc14504c870b60055e
src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
src/tests/slave_recovery_tests.cpp 0b17a8afb6aa66ab19f6fcd90906fb4eb2c39f05
Diff: https://reviews.apache.org/r/24128/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 24128: Add 'max_num_executors' flag for use with network
isolation
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/
-----------------------------------------------------------
(Updated Aug. 1, 2014, 5:03 p.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Changes
-------
response to jie
Bugs: MESOS-1654
https://issues.apache.org/jira/browse/MESOS-1654
Repository: mesos-git
Description
-------
when network isolation is enabled, we should keep track of how many executors have launched on a given host to avoid sending offers for those that have hit the container limit.
this is a short-term fix for the issue to enable broader testing of network monitoring and isolation.
Diffs (updated)
-----
docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
src/master/master.cpp 77f2536c36df9a0a1f6021bd4732baa3ab424459
src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
src/tests/master_tests.cpp 5a1cf7f1f7a4864f516825cc14504c870b60055e
src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
src/tests/slave_recovery_tests.cpp 0b17a8afb6aa66ab19f6fcd90906fb4eb2c39f05
Diff: https://reviews.apache.org/r/24128/diff/
Testing
-------
make check
Thanks,
Dominic Hamon