You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/02/24 21:19:56 UTC
[Impala-ASF-CR] [DOCS] Remove reference to CDH 4 from DECIMAL page
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6146
Change subject: [DOCS] Remove reference to CDH 4 from DECIMAL page
......................................................................
[DOCS] Remove reference to CDH 4 from DECIMAL page
Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
---
M docs/topics/impala_decimal.xml
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/6146/1
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
Patch Set 4: Code-Review+1
Build looks good.
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Ambreen Kazi,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6146
to look at the new patch set (#4).
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Along the way, remove nearby references to CDH 5
and especially the CDH version numbers in the
'Fixed Issues' titles. The fixed issues titles
are not amenable to the keydef/keyref substitution
technique because they are all 3-part numbers
like Impala 2.2.1 that don't have substitution
variables defined for them.
Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
---
M docs/impala.ditamap
M docs/topics/impala_avro.xml
M docs/topics/impala_char.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_install.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_noncm_installation.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_perf_resources.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_subqueries.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
15 files changed, 69 insertions(+), 117 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/6146/4
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
Patch Set 4:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/52/
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Remove reference to CDH 4 from DECIMAL page
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: [DOCS] Remove reference to CDH 4 from DECIMAL page
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Along the way, remove nearby references to CDH 5
and especially the CDH version numbers in the
'Fixed Issues' titles. The fixed issues titles
are not amenable to the keydef/keyref substitution
technique because they are all 3-part numbers
like Impala 2.2.1 that don't have substitution
variables defined for them.
Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Reviewed-on: http://gerrit.cloudera.org:8080/6146
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_avro.xml
M docs/topics/impala_char.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_install.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_noncm_installation.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_perf_resources.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_subqueries.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
14 files changed, 68 insertions(+), 111 deletions(-)
Approvals:
Impala Public Jenkins: Verified
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
Patch Set 6:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/57/
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
Patch Set 4:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/55/
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, Ambreen Kazi,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6146
to look at the new patch set (#6).
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Along the way, remove nearby references to CDH 5
and especially the CDH version numbers in the
'Fixed Issues' titles. The fixed issues titles
are not amenable to the keydef/keyref substitution
technique because they are all 3-part numbers
like Impala 2.2.1 that don't have substitution
variables defined for them.
Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
---
M docs/topics/impala_avro.xml
M docs/topics/impala_char.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_install.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_noncm_installation.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_perf_resources.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_subqueries.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
14 files changed, 68 insertions(+), 111 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/6146/6
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6146/3/docs/topics/impala_avro.xml
File docs/topics/impala_avro.xml:
PS3, Line 257: CDH
CDH reference.
http://gerrit.cloudera.org:8080/#/c/6146/3/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:
PS3, Line 2409: <li conref="cdh_rn_fixed_in_53
will these conrefs be replaced with text?
http://gerrit.cloudera.org:8080/#/c/6146/3/docs/topics/impala_udf.xml
File docs/topics/impala_udf.xml:
PS3, Line 417: ev="CDH-37080"
remove CDH jira?
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Remove reference to CDH 4 from DECIMAL page
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Remove reference to CDH 4 from DECIMAL page
......................................................................
Patch Set 1:
??? Can't see +1/+2 buttons when I attempt to post. Happens at multiple screen resolutions, on all browsers. Posting a dummy comment to see if that clears it up.
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Remove reference to CDH 4 from DECIMAL page
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: [DOCS] Remove reference to CDH 4 from DECIMAL page
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6146/1/docs/topics/impala_decimal.xml
File docs/topics/impala_decimal.xml:
PS1, Line 721: CDH 4
Remove 'CDH 4'.
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6146/3/docs/topics/impala_avro.xml
File docs/topics/impala_avro.xml:
PS3, Line 257: CDH
> CDH reference.
Done
http://gerrit.cloudera.org:8080/#/c/6146/3/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:
PS3, Line 2409: <li conref="cdh_rn_fixed_in_53
> will these conrefs be replaced with text?
Not at this time. Might be a later work item but for now the upstream fixed issues are primarily pointers to JIRA reports.
http://gerrit.cloudera.org:8080/#/c/6146/3/docs/topics/impala_udf.xml
File docs/topics/impala_udf.xml:
PS3, Line 417: ev="CDH-37080"
> remove CDH jira?
I did the same in a few places throughout this file.
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Ambreen Kazi,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6146
to look at the new patch set (#3).
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Along the way, remove nearby references to CDH 5
and especially the CDH version numbers in the
'Fixed Issues' titles. The fixed issues titles
are not amenable to the keydef/keyref substitution
technique because they are all 3-part numbers
like Impala 2.2.1 that don't have substitution
variables defined for them.
Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
---
M docs/impala.ditamap
M docs/topics/impala_avro.xml
M docs/topics/impala_char.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_install.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_noncm_installation.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_perf_resources.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_subqueries.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
15 files changed, 63 insertions(+), 111 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/6146/3
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
Patch Set 5:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/56/
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
Patch Set 5: Code-Review+2
Didn't run into any issues rebasing against asf-master. Going to try merging again. If problem persists, will rebase against asf-gerrit instead.
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Remove reference to CDH 4 from DECIMAL page
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Remove reference to CDH 4 from DECIMAL page
......................................................................
Patch Set 1:
(1 comment)
Think I'm finished!
http://gerrit.cloudera.org:8080/#/c/6146/1/docs/topics/impala_decimal.xml
File docs/topics/impala_decimal.xml:
PS1, Line 721: CDH 4
> Remove 'CDH 4'.
Done
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Remove reference to CDH 4 from DECIMAL page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: [DOCS] Remove reference to CDH 4 from DECIMAL page
......................................................................
Patch Set 1:
> ??? Can't see +1/+2 buttons when I attempt to post. Happens at
> multiple screen resolutions, on all browsers. Posting a dummy
> comment to see if that clears it up.
You can only +1/+2 the most recent patchset of a patch.
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Remove reference to CDH 4 from DECIMAL page
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: [DOCS] Remove reference to CDH 4 from DECIMAL page
......................................................................
[DOCS] Remove reference to CDH 4 from DECIMAL page
Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
---
M docs/topics/impala_decimal.xml
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/6146/2
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
Patch Set 2:
(1 comment)
Since I was help up in finalizing this review, I repurposed it to be more substantial and will ask Ambreen to doublecheck again. (Original patchset was intended to be a minor change for gerrit demo purposes.)
http://gerrit.cloudera.org:8080/#/c/6146/2/docs/topics/impala_decimal.xml
File docs/topics/impala_decimal.xml:
PS2, Line 721:
> Is there an equivalent Impala version number you could reference?
No, this was back in the days before there was any close correspondences between the Impala and CDH numbers. It is purely a case of "use really old CDH, watch out". Now that CDH 4 is end-of-maintenance, even in CDH docs it's fair game to remove such references.
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................
Patch Set 6: Code-Review+2
Rebased against asf-gerrit
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Remove reference to CDH 4 from DECIMAL page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: [DOCS] Remove reference to CDH 4 from DECIMAL page
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6146/2/docs/topics/impala_decimal.xml
File docs/topics/impala_decimal.xml:
PS2, Line 721:
Is there an equivalent Impala version number you could reference?
--
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes