You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/01/22 09:23:40 UTC

[GitHub] ivankelly closed pull request #1022: Only run integration tests with -DintegrationTests

ivankelly closed pull request #1022: Only run integration tests with -DintegrationTests
URL: https://github.com/apache/bookkeeper/pull/1022
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tests/docker-all-versions-image/pom.xml b/tests/docker-all-versions-image/pom.xml
index 365f8b317..001199a12 100644
--- a/tests/docker-all-versions-image/pom.xml
+++ b/tests/docker-all-versions-image/pom.xml
@@ -40,6 +40,11 @@
   <profiles>
     <profile>
       <id>docker</id>
+      <activation>
+        <property>
+          <name>integrationTests</name>
+        </property>
+      </activation>
       <build>
         <plugins>
           <plugin>
diff --git a/tests/integration-tests-base/pom.xml b/tests/integration-tests-base/pom.xml
index f55569a2c..bf053e695 100644
--- a/tests/integration-tests-base/pom.xml
+++ b/tests/integration-tests-base/pom.xml
@@ -63,6 +63,8 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-plugin</artifactId>
         <configuration>
+          <!-- only run tests when -DintegrationTests is specified //-->
+          <skipTests>true</skipTests>
           <systemPropertyVariables>
             <currentVersion>${project.version}</currentVersion>
             <maven.buildDirectory>${project.build.directory}</maven.buildDirectory>
@@ -72,4 +74,25 @@
     </plugins>
   </build>
 
+  <profiles>
+    <profile>
+      <id>integrationTests</id>
+      <activation>
+        <property>
+          <name>integrationTests</name>
+        </property>
+      </activation>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-surefire-plugin</artifactId>
+            <configuration>
+              <skipTests>false</skipTests>
+            </configuration>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
+  </profiles>
 </project>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services