You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2017/06/05 19:44:04 UTC
[jira] [Commented] (ARROW-1090) [Python] build_ext usability
[ https://issues.apache.org/jira/browse/ARROW-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037457#comment-16037457 ]
Wes McKinney commented on ARROW-1090:
-------------------------------------
I ran into this while trying to test out your patch for ARROW-1086. This is a pretty rough edge, would you mind submitting a patch? It doesn't seem like this should fail, so if it's possible to make it pass that would be great. Updating the documentation would also be very nice.
> [Python] build_ext usability
> ----------------------------
>
> Key: ARROW-1090
> URL: https://issues.apache.org/jira/browse/ARROW-1090
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Jacob Scott
> Priority: Minor
> Fix For: 0.5.0
>
>
> I believe (based on some confusing time with the build toolchain) that
> * If {{ARROW_HOME}} is set, attempting to build_ext with {{PYARROW_BUNDLE_ARROW_CPP}} will fail because {{FindArrow.cmake}} will not set {{ARROW_ABI_VERSION}}.
> * {{PKG_CONFIG_PATH}} must be set correctly for a bundled build to work.
> * {{--bundle-arrow-cpp}} may not do anything (vs {{PYARROW_BUNDLE_ARROW_CPP}}), but is referenced in build scripts.
> I'd be happy to submit a PR which checks for some of these conditions in setup.py and bails with a helpful message, and/or update {{development.rst}} to include a wheel-building block.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)