You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/11/17 22:36:36 UTC
[GitHub] [trafficcontrol] mitchell852 opened a new issue #5295: AG-Grid: Invalid method call to clear table filters
mitchell852 opened a new issue #5295:
URL: https://github.com/apache/trafficcontrol/issues/5295
## I'm submitting a ...
- bug report
## Traffic Control components affected ...
- Traffic Portal
## Current behavior:
https://tp.domain.tld/#!/types/253/servers
## Expected behavior:
Should be `Clear Table Filters` and call the `clearTableFilters()` function.
## Minimal reproduction of the problem with instructions:
Navigate to https://tp.domain.tld/#!/types/253/servers and try to clear the filters. It does nothing because it's calling a function that was renamed.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #5295: TP: Invalid method call to clear ag-grid table filters
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5295:
URL: https://github.com/apache/trafficcontrol/issues/5295#issuecomment-729289831
I don't think you need to re-name the button to do that. In fact, "Clear Table Filters" sounds like it'll also clear the page size and "Quick search..." filters, not just the filters on the columns. Which I don't think it does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp closed issue #5295: TP: Invalid method call to clear ag-grid table filters
Posted by GitBox <gi...@apache.org>.
rawlinp closed issue #5295:
URL: https://github.com/apache/trafficcontrol/issues/5295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on issue #5295: TP: Invalid method call to clear ag-grid table filters
Posted by GitBox <gi...@apache.org>.
shamrickus commented on issue #5295:
URL: https://github.com/apache/trafficcontrol/issues/5295#issuecomment-740924596
Fixed by #5321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #5295: TP: Invalid method call to clear ag-grid table filters
Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #5295:
URL: https://github.com/apache/trafficcontrol/issues/5295#issuecomment-729791984
yeah, `Clear Table Filters` actually does clear the quick search as well..hence the reason i renamed it....but does not reset the page size (maybe it should. not sure. it's not really a _filter_)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #5295: TP: Invalid method call to clear ag-grid table filters
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5295:
URL: https://github.com/apache/trafficcontrol/issues/5295#issuecomment-729800808
Idk I'd consider the pagination filtering for the first N results. But even if it only clears the quick search, I think that's a good rename :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on issue #5295: TP: Invalid method call to clear ag-grid table filters
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #5295:
URL: https://github.com/apache/trafficcontrol/issues/5295#issuecomment-729791984
yeah, `Clear Table Filters` actually does clear the quick search as well..hence the reason i renamed it....but does not reset the page size (maybe it should. not sure.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org