You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/07/21 14:32:52 UTC
Review Request 61032: Fixed slaves_unreachable metric.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61032/
-----------------------------------------------------------
Review request for mesos, Armand Grillet and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f
Diff: https://reviews.apache.org/r/61032/diff/1/
Testing
-------
See https://reviews.apache.org/r/61034/
Thanks,
Alexander Rukletsov
Re: Review Request 61032: Fixed slaves_unreachable metric.
Posted by Vinod Kone <vi...@gmail.com>.
> On July 25, 2017, 10:06 p.m., Vinod Kone wrote:
> > src/master/metrics.cpp
> > Lines 223 (patched)
> > <https://reviews.apache.org/r/61032/diff/1/?file=1780700#file1780700line223>
> >
> > Ideally our tests should've caught this :( Can you please update the metrics test to verify this metric?
> >
> > Also, please write a meaningful description that explains the issue and the fix; it's not at all clear from the summary.
I see that you fixed that in the next review; would be nice if you indicated it in the review description or testing done to give me a hint. Alternatively, I would've included the test update for this particular metric in this patch.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61032/#review181392
-----------------------------------------------------------
On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61032/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 2:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f
>
>
> Diff: https://reviews.apache.org/r/61032/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/61034/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61032: Fixed slaves_unreachable metric.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61032/#review181392
-----------------------------------------------------------
src/master/metrics.cpp
Lines 223 (patched)
<https://reviews.apache.org/r/61032/#comment256926>
Ideally our tests should've caught this :( Can you please update the metrics test to verify this metric?
Also, please write a meaningful description that explains the issue and the fix; it's not at all clear from the summary.
- Vinod Kone
On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61032/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 2:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f
>
>
> Diff: https://reviews.apache.org/r/61032/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/61034/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61032: Fixed slaves_unreachable metric.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On July 22, 2017, 10:47 a.m., Armand Grillet wrote:
> > Regarding the summary: is this a fix? This looks like the addition of one metric and there is no bug linked to the review request (except [MESOS-7747](https://issues.apache.org/jira/browse/MESOS-7747) at the beginning of the chain but it is of type _Improvement_).
It is a fix, because before the metric was not actually used. For this kind of (minor) bugs, we don't necessarily create a ticket (but we may). Since there are no existing issues mentioning this bug, I have decided not to create one to avoid extra work and JIRA pollution.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61032/#review181173
-----------------------------------------------------------
On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61032/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 2:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f
>
>
> Diff: https://reviews.apache.org/r/61032/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/61034/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61032: Fixed slaves_unreachable metric.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61032/#review181173
-----------------------------------------------------------
Ship it!
Regarding the summary: is this a fix? This looks like the addition of one metric and there is no bug linked to the review request (except [MESOS-7747](https://issues.apache.org/jira/browse/MESOS-7747) at the beginning of the chain but it is of type _Improvement_).
- Armand Grillet
On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61032/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 2:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f
>
>
> Diff: https://reviews.apache.org/r/61032/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/61034/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61032: Fixed slaves_unreachable metric.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61032/#review181998
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On July 28, 2017, 2:40 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61032/
> -----------------------------------------------------------
>
> (Updated July 28, 2017, 2:40 p.m.)
>
>
> Review request for mesos, Armand Grillet and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While a gauge for slaves_unreachable was created in master metrics,
> it was not added to the metrics actor and hence was not tracked by
> the metrics subsystem.
>
>
> Diffs
> -----
>
> src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f
>
>
> Diff: https://reviews.apache.org/r/61032/diff/2/
>
>
> Testing
> -------
>
> Augemnted an appropriate test with a check for this metric in https://reviews.apache.org/r/61033/
>
> See https://reviews.apache.org/r/61030/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61032: Fixed slaves_unreachable metric.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61032/
-----------------------------------------------------------
(Updated July 28, 2017, 2:40 p.m.)
Review request for mesos, Armand Grillet and Vinod Kone.
Repository: mesos
Description
-------
While a gauge for slaves_unreachable was created in master metrics,
it was not added to the metrics actor and hence was not tracked by
the metrics subsystem.
Diffs (updated)
-----
src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f
Diff: https://reviews.apache.org/r/61032/diff/2/
Changes: https://reviews.apache.org/r/61032/diff/1-2/
Testing (updated)
-------
Augemnted an appropriate test with a check for this metric in https://reviews.apache.org/r/61033/
See https://reviews.apache.org/r/61030/
Thanks,
Alexander Rukletsov
Re: Review Request 61032: Fixed slaves_unreachable metric.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61032/
-----------------------------------------------------------
(Updated July 28, 2017, 2:10 p.m.)
Review request for mesos, Armand Grillet and Vinod Kone.
Repository: mesos
Description
-------
While a gauge for slaves_unreachable was created in master metrics,
it was not added to the metrics actor and hence was not tracked by
the metrics subsystem.
Diffs
-----
src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f
Diff: https://reviews.apache.org/r/61032/diff/1/
Testing (updated)
-------
Augemnted an appropriate test with a check for this metric in https://reviews.apache.org/r/61033/
See https://reviews.apache.org/r/61034/
Thanks,
Alexander Rukletsov
Re: Review Request 61032: Fixed slaves_unreachable metric.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61032/
-----------------------------------------------------------
(Updated July 28, 2017, 2:07 p.m.)
Review request for mesos, Armand Grillet and Vinod Kone.
Repository: mesos
Description (updated)
-------
While a gauge for slaves_unreachable was created in master metrics,
it was not added to the metrics actor and hence was not tracked by
the metrics subsystem.
Diffs
-----
src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f
Diff: https://reviews.apache.org/r/61032/diff/1/
Testing
-------
See https://reviews.apache.org/r/61034/
Thanks,
Alexander Rukletsov