You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/09/26 15:25:19 UTC
[GitHub] rawlinp commented on a change in pull request #2853: Finish up DS
SSL keys endpoints in TO Go
rawlinp commented on a change in pull request #2853: Finish up DS SSL keys endpoints in TO Go
URL: https://github.com/apache/trafficcontrol/pull/2853#discussion_r220611425
##########
File path: lib/go-tc/deliveryservice_ssl_keys.go
##########
@@ -34,25 +34,18 @@ type DeliveryServiceSSLKeysResponse struct {
Response DeliveryServiceSSLKeys `json:"response"`
}
-// DeliveryServiceSSLKeysCertificate ...
-type DeliveryServiceSSLKeysCertificate struct {
- Crt string `json:"crt"`
- Key string `json:"key"`
- CSR string `json:"csr"`
-}
-
// DeliveryServiceSSLKeys ...
type DeliveryServiceSSLKeys struct {
CDN string `json:"cdn,omitempty"`
- DeliveryService string `json:"DeliveryService,omitempty"`
+ DeliveryService string `json:"deliveryservice,omitempty"`
BusinessUnit string `json:"businessUnit,omitempty"`
City string `json:"city,omitempty"`
Organization string `json:"organization,omitempty"`
Hostname string `json:"hostname,omitempty"`
Country string `json:"country,omitempty"`
State string `json:"state,omitempty"`
Key string `json:"key"`
- Version util.JSONNumAsStr `json:"version"`
+ Version util.JSONIntStr `json:"version"`
Review comment:
So the version in the Riak record json itself should never be "latest". The version in the Riak key that the record is stored under, e.g. `ssl/<xml_id>-<version>`, can be "latest". But the record specified by that key has the actual version int in it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services