You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/21 17:56:55 UTC

[GitHub] [pulsar] WJL3333 commented on a change in pull request #9663: Fix Pulsar SQL query compression data

WJL3333 commented on a change in pull request #9663:
URL: https://github.com/apache/pulsar/pull/9663#discussion_r579841909



##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/api/raw/MessageParser.java
##########
@@ -74,7 +74,7 @@ public static void parseMessage(TopicName topicName, long ledgerId, long entryId
                 return;
             }
 
-            refCntMsgMetadata = ReferenceCountedMessageMetadata.get();
+            refCntMsgMetadata = ReferenceCountedMessageMetadata.get(headersAndPayload);

Review comment:
       hello,i wonder if this can only retain buffer for headers only. it seems `ReferenceCountedMessageMetadata` may make buffer live a bit longer which may contain the payload.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org