[jira] [Commented] (GEODE-4134) RegionVersionVectorTest.doesNotHangIfOtherThreadChangedVersion has potential to hang

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299119#comment-16299119 ] 

ASF GitHub Bot commented on GEODE-4134:
---------------------------------------

kirklund opened a new pull request #1195: GEODE-4134: use ExecutorService for CompletableFuture
URL: https://github.com/apache/geode/pull/1195
 
 
   By using an ExecutorService, tearDown can invoke shutdownNow which will interrupt any Executor task threads including the hung thread in doesNotHangIfOtherThreadChangedVersion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> RegionVersionVectorTest.doesNotHangIfOtherThreadChangedVersion has potential to hang
> ------------------------------------------------------------------------------------
>
>                 Key: GEODE-4134
>                 URL: https://issues.apache.org/jira/browse/GEODE-4134
>             Project: Geode
>          Issue Type: Bug
>          Components: tests
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>
> RegionVersionVectorTest.doesNotHangIfOtherThreadChangedVersion has potential to hang if the bug is reintroduced. The reason is that CompletableFuture cancel(true) does not interrupt the thread executing the task. Specifying an ExecutorService and invoking shutdownNow fixes this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)