You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/12 22:28:36 UTC

[GitHub] [beam] dmvk commented on a change in pull request #13540: WIP: [BEAM-1850] Flink Streaming - Don't explode KeyedWorkItems before shuffle.

dmvk commented on a change in pull request #13540:
URL: https://github.com/apache/beam/pull/13540#discussion_r541793079



##########
File path: runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingTransformTranslators.java
##########
@@ -911,15 +911,14 @@ public void translateNode(
               ByteArrayCoder.of(),
               input.getWindowingStrategy().getWindowFn().windowCoder());
 
-      DataStream<WindowedValue<KV<K, InputT>>> inputDataStream = context.getInputDataStream(input);
-
-      WindowedValue.FullWindowedValueCoder<KeyedWorkItem<K, byte[]>> windowedWorkItemCoder =
-          WindowedValue.getFullCoder(
-              workItemCoder, input.getWindowingStrategy().getWindowFn().windowCoder());
+      Coder<WindowedValue<KeyedWorkItem<K, byte[]>>> windowedWorkItemCoder =
+          WindowedValue.getParamWindowedValueCoder(workItemCoder);

Review comment:
       We only need to encode window / ts / ... in KWI




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org