[GitHub] licl2014 commented on issue #6790: chooseBestServer bug in CostBalancerStrategy

[GitBox <gi...@apache.org>]

licl2014 commented on issue #6790: chooseBestServer bug in CostBalancerStrategy
URL: https://github.com/apache/incubator-druid/issues/6790#issuecomment-452189552
 
 
   @QiuMM thanks for your reply, if  `resultsFuture.get()` has only one element and the element is `Double.POSITIVE_INFINITY`, we should not assign segment on it,but now our processing logic as follows:
   >   if (server.lhs <= bestServers.get(0).lhs) { //eg. `<Double.POSITIVE_INFINITY, node1>`
   >       if (server.lhs < bestServers.get(0).lhs) {// `but we can't get here`
   >      bestServers.clear();
   >     }
   >     bestServers.add(server);//`so it will be added in bestServers`
   >   }

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org