You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/09/17 13:07:11 UTC

Review Request 62368: Stack Advisor can reset the number of shards (Log Search) during adding a new service (BP install)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62368/
-----------------------------------------------------------

Review request for Ambari, Attila Doroszlai, Miklos Gergely, Robert Nettleton, and Sebastian Toader.


Bugs: AMBARI-21975
    https://issues.apache.org/jira/browse/AMBARI-21975


Repository: ambari


Description
-------

The default value for the number of shards is 5. On UI install, the proper value is calculated, the max values is 3x number of solr instances. If you have only 1 Solr and Log Search was installed with BP without any custom shard config, the shard max value will be 3, but in fact the actual one is 5, that can cause during adding a new service through the UI can reset the number of shards. To fix that: set the max number of shard value to 5, in case you have just 1 solr ( use: max (3x solrs, 5))


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py f0d9f78 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py ff57c7b 


Diff: https://reviews.apache.org/r/62368/diff/1/


Testing
-------

done. (updated unit tests)


Thanks,

Oliver Szabo


Re: Review Request 62368: Stack Advisor can reset the number of shards (Log Search) during adding a new service (BP install)

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62368/#review185529
-----------------------------------------------------------


Ship it!




Ship It!

- Miklos Gergely


On Sept. 17, 2017, 1:07 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62368/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2017, 1:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Miklos Gergely, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21975
>     https://issues.apache.org/jira/browse/AMBARI-21975
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The default value for the number of shards is 5. On UI install, the proper value is calculated, the max values is 3x number of solr instances. If you have only 1 Solr and Log Search was installed with BP without any custom shard config, the shard max value will be 3, but in fact the actual one is 5, that can cause during adding a new service through the UI can reset the number of shards. To fix that: set the max number of shard value to 5, in case you have just 1 solr ( use: max (3x solrs, 5))
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py f0d9f78 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py ff57c7b 
> 
> 
> Diff: https://reviews.apache.org/r/62368/diff/1/
> 
> 
> Testing
> -------
> 
> done. (updated unit tests)
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>