[GitHub] [maven-verifier-plugin] slachiewicz commented on a change in pull request #1: Use new version of site and thoughts about new release

[GitBox <gi...@apache.org>]

slachiewicz commented on a change in pull request #1: Use new version of site and thoughts about new release
URL: https://github.com/apache/maven-verifier-plugin/pull/1#discussion_r365546471
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/verifier/VerifierMojo.java
 ##########
 @@ -123,17 +122,11 @@ private VerificationResult verify()
     {
         VerificationResult results = new VerificationResult();
 
-        Reader reader = null;
-        try
+        try ( Reader reader = new FileReader( this.verificationFile ) )
 
 Review comment:
   good catch - @KroArtem  could you create Jira and pr to fix that?
   maybe this can be useful https://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#newBufferedReader(java.nio.file.Path,%20java.nio.charset.Charset) ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services