[GitHub] [spark] cloud-fan commented on a diff in pull request #37452: [SPARK-40018][SQL][TESTS] Output `SparkThrowable` to SQL golden files in JSON format

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #37452:
URL: https://github.com/apache/spark/pull/37452#discussion_r942656352


##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestHelper.scala:
##########
@@ -71,6 +76,30 @@ trait SQLQueryTestHelper {
     if (isSorted(df.queryExecution.analyzed)) (schema, answer) else (schema, answer.sorted)
   }
 
+  private def toJson(e: SparkThrowable): String = {

Review Comment:
   I have the same question: shall we add a user-facing feature first that allows users to enable JSON style error message? Due to the low coverage of error classes today, I'd also suggest keeping the message unchanged for errors without error classes (no JSON).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org