Re: [I] Protocol negotiation isn't correctly determining protocol version for at least some Cassandra versions [cassandra-gocql-driver]

["worryg0d (via GitHub)" <gi...@apache.org>]

worryg0d commented on issue #1911:
URL: https://github.com/apache/cassandra-gocql-driver/issues/1911#issuecomment-3455429786

   Hello. 
   
   I tried to reproduce this issue against the 2.0.0 gocql release and didn't get any panics. The driver successfully detected the latest supported protocol version as v4 for DSE 6.9 / Cassandra 3.11, so no v5 checksum mismatches there.
   
   When I was implementing support for v5 protocol, I somehow missed this beta flag, so this is my bad. I actually expected this change to break something for older Cassandra versions because gocql supported a v5 beta, which is significantly different from v5 proto final version, but I assumed that it was fine since gocql didn't support older Cassandra versions, and it is not being tested against them.
   
   Anyway, thanks @joao-r-reis for fixing it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org