You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by nishadi <gi...@git.apache.org> on 2017/05/26 14:47:09 UTC

[GitHub] gora pull request #102: GORA-324 Port work done on old GoraCompiler to new G...

GitHub user nishadi opened a pull request:

    https://github.com/apache/gora/pull/102

    GORA-324 Port work done on old GoraCompiler to new GoraCompiler

    This PR includes enhancements to the gora-compiler as follows.
    
    - add license headers to generated files
    
    - adds the ability to compile files in a directory.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nishadi/gora issue-324

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #102
    
----
commit 3a4f1390673ea29f96be1166a8f28fee4bd7444a
Author: nishadi <nd...@gmail.com>
Date:   2017-05-22T16:35:19Z

    Add ability to compile files in a directory via gora-compiler

commit 1d6c83204bcf94adc7b8b092a615303c54c4bf9e
Author: nishadi <nd...@gmail.com>
Date:   2017-05-26T14:40:17Z

    Generate license to the compiled files

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #102: GORA-324 Port work done on old GoraCompiler to new GoraComp...

Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on the issue:

    https://github.com/apache/gora/pull/102
  
    +1 from my end as well, great work @nishadi :) Thank you for the contribution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #102: GORA-324 Port work done on old GoraCompiler to new GoraComp...

Posted by nishadi <gi...@git.apache.org>.
Github user nishadi commented on the issue:

    https://github.com/apache/gora/pull/102
  
    Thank you for merging :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #102: GORA-324 Port work done on old GoraCompiler to new G...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/gora/pull/102


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #102: GORA-324 Port work done on old GoraCompiler to new GoraComp...

Posted by nishadi <gi...@git.apache.org>.
Github user nishadi commented on the issue:

    https://github.com/apache/gora/pull/102
  
    Hi, Thank you. I have amended the formatting fixes to the existing commit. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #102: GORA-324 Port work done on old GoraCompiler to new GoraComp...

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/gora/pull/102
  
    +1 to merge to master... anyone else want to review? Thank you @nishadi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #102: GORA-324 Port work done on old GoraCompiler to new GoraComp...

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/gora/pull/102
  
    Thank you @nishadi merged into master branch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---