You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/09/28 00:19:50 UTC
Review Request 62643: Propagated the container termination to the
agent API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62643/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Qian Zhang.
Bugs: MESOS-7963
https://issues.apache.org/jira/browse/MESOS-7963
Repository: mesos
Description
-------
Updated the agent API so that we can propagate information
from the container termination up to the `WaitNestedContainer`
response. We now propagate resources all the way from the
container limitation to the `WaitNestedContainer` response so
that an executor can know specifically which resource limit
violation caused the container termination.
Diffs
-----
include/mesos/agent/agent.proto 7c8c8a7d8298e91e4e002327b3b27d4c74b5cbae
include/mesos/slave/containerizer.proto 84f9ca765fe6e29ddd2f7956ba0976e10b21d685
include/mesos/v1/agent/agent.proto 3e199124b23fa027232790d99370fe2f33660096
src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345
src/slave/http.cpp 3ea7829df8c1c35d2fa3a44f19a60b7e261042ce
Diff: https://reviews.apache.org/r/62643/diff/1/
Testing
-------
make check (Fedora 26)
Thanks,
James Peach
Re: Review Request 62643: Propagated the container termination to the
agent API.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62643/#review186962
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/agent/agent.proto
Lines 338 (patched)
<https://reviews.apache.org/r/62643/#comment263902>
Please add some comment about this field. So basically, if specified, this `state` should be used for the task that is associated with this container.
include/mesos/agent/agent.proto
Lines 346 (patched)
<https://reviews.apache.org/r/62643/#comment263900>
Can you rename this to `limited_resources` to be in sync with that in `TaskStatus`?
include/mesos/slave/containerizer.proto
Lines 256 (patched)
<https://reviews.apache.org/r/62643/#comment263903>
Ditto. `limited_resources`
include/mesos/v1/agent/agent.proto
Lines 338-346 (patched)
<https://reviews.apache.org/r/62643/#comment263905>
Ditto.
- Jie Yu
On Sept. 28, 2017, 12:19 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62643/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2017, 12:19 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-7963
> https://issues.apache.org/jira/browse/MESOS-7963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the agent API so that we can propagate information
> from the container termination up to the `WaitNestedContainer`
> response. We now propagate resources all the way from the
> container limitation to the `WaitNestedContainer` response so
> that an executor can know specifically which resource limit
> violation caused the container termination.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto 7c8c8a7d8298e91e4e002327b3b27d4c74b5cbae
> include/mesos/slave/containerizer.proto 84f9ca765fe6e29ddd2f7956ba0976e10b21d685
> include/mesos/v1/agent/agent.proto 3e199124b23fa027232790d99370fe2f33660096
> src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345
> src/slave/http.cpp 3ea7829df8c1c35d2fa3a44f19a60b7e261042ce
>
>
> Diff: https://reviews.apache.org/r/62643/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 62643: Propagated the container termination to the
agent API.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62643/#review188079
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Oct. 10, 2017, 8:08 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62643/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2017, 8:08 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-7963
> https://issues.apache.org/jira/browse/MESOS-7963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the agent API so that we can propagate information
> from the container termination up to the `WaitNestedContainer`
> response. We now propagate resources all the way from the
> container limitation to the `WaitNestedContainer` response so
> that an executor can know specifically which resource limit
> violation caused the container termination.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto 7c8c8a7d8298e91e4e002327b3b27d4c74b5cbae
> include/mesos/slave/containerizer.proto 84f9ca765fe6e29ddd2f7956ba0976e10b21d685
> include/mesos/v1/agent/agent.proto 3e199124b23fa027232790d99370fe2f33660096
> src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345
> src/slave/http.cpp f4c3e6b5ec2943806c78ba3ca524588a655c5bb7
>
>
> Diff: https://reviews.apache.org/r/62643/diff/3/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 62643: Propagated the container termination to the
agent API.
Posted by James Peach <jp...@apache.org>.
> On Oct. 11, 2017, 12:18 p.m., Qian Zhang wrote:
> > include/mesos/agent/agent.proto
> > Lines 347 (patched)
> > <https://reviews.apache.org/r/62643/diff/2/?file=1850015#file1850015line347>
> >
> > Can you elaborate a bit about why wrapping `repeated Resource resources = 4;` into a new message `TaskResourceLimitation`?
It was asked for on the dev@ list [here](https://lists.apache.org/thread.html/1d237deea2f678bed3f30a96fc9f068949ba9a08099acf3f48d53741@%3Cdev.mesos.apache.org%3E).
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62643/#review187639
-----------------------------------------------------------
On Oct. 10, 2017, 12:08 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62643/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2017, 12:08 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-7963
> https://issues.apache.org/jira/browse/MESOS-7963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the agent API so that we can propagate information
> from the container termination up to the `WaitNestedContainer`
> response. We now propagate resources all the way from the
> container limitation to the `WaitNestedContainer` response so
> that an executor can know specifically which resource limit
> violation caused the container termination.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto 7c8c8a7d8298e91e4e002327b3b27d4c74b5cbae
> include/mesos/slave/containerizer.proto 84f9ca765fe6e29ddd2f7956ba0976e10b21d685
> include/mesos/v1/agent/agent.proto 3e199124b23fa027232790d99370fe2f33660096
> src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345
> src/slave/http.cpp f4c3e6b5ec2943806c78ba3ca524588a655c5bb7
>
>
> Diff: https://reviews.apache.org/r/62643/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 62643: Propagated the container termination to the
agent API.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62643/#review187639
-----------------------------------------------------------
include/mesos/agent/agent.proto
Lines 347 (patched)
<https://reviews.apache.org/r/62643/#comment264705>
Can you elaborate a bit about why wrapping `repeated Resource resources = 4;` into a new message `TaskResourceLimitation`?
src/slave/containerizer/mesos/containerizer.cpp
Lines 2698 (patched)
<https://reviews.apache.org/r/62643/#comment264699>
Kill this blank line.
- Qian Zhang
On Oct. 10, 2017, 8:08 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62643/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2017, 8:08 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-7963
> https://issues.apache.org/jira/browse/MESOS-7963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the agent API so that we can propagate information
> from the container termination up to the `WaitNestedContainer`
> response. We now propagate resources all the way from the
> container limitation to the `WaitNestedContainer` response so
> that an executor can know specifically which resource limit
> violation caused the container termination.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto 7c8c8a7d8298e91e4e002327b3b27d4c74b5cbae
> include/mesos/slave/containerizer.proto 84f9ca765fe6e29ddd2f7956ba0976e10b21d685
> include/mesos/v1/agent/agent.proto 3e199124b23fa027232790d99370fe2f33660096
> src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345
> src/slave/http.cpp f4c3e6b5ec2943806c78ba3ca524588a655c5bb7
>
>
> Diff: https://reviews.apache.org/r/62643/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 62643: Propagated the container termination to the
agent API.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62643/
-----------------------------------------------------------
(Updated Oct. 10, 2017, 12:08 a.m.)
Review request for mesos, Jie Yu and Qian Zhang.
Changes
-------
Rebased onto `TaskResourceLimitation` protobuf message.
Bugs: MESOS-7963
https://issues.apache.org/jira/browse/MESOS-7963
Repository: mesos
Description
-------
Updated the agent API so that we can propagate information
from the container termination up to the `WaitNestedContainer`
response. We now propagate resources all the way from the
container limitation to the `WaitNestedContainer` response so
that an executor can know specifically which resource limit
violation caused the container termination.
Diffs (updated)
-----
include/mesos/agent/agent.proto 7c8c8a7d8298e91e4e002327b3b27d4c74b5cbae
include/mesos/slave/containerizer.proto 84f9ca765fe6e29ddd2f7956ba0976e10b21d685
include/mesos/v1/agent/agent.proto 3e199124b23fa027232790d99370fe2f33660096
src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345
src/slave/http.cpp f4c3e6b5ec2943806c78ba3ca524588a655c5bb7
Diff: https://reviews.apache.org/r/62643/diff/2/
Changes: https://reviews.apache.org/r/62643/diff/1-2/
Testing
-------
make check (Fedora 26)
Thanks,
James Peach