You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/19 17:06:26 UTC

[GitHub] [spark] JoshRosen commented on a diff in pull request #37573: [SPARK-40141][CORE] Remove unnecessary TaskContext addTaskXxxListener overloads

JoshRosen commented on code in PR #37573:
URL: https://github.com/apache/spark/pull/37573#discussion_r950405113


##########
core/src/main/scala/org/apache/spark/TaskContext.scala:
##########
@@ -113,48 +115,21 @@ abstract class TaskContext extends Serializable {
    *
    * Exceptions thrown by the listener will result in failure of the task.
    */
+  @DeveloperApi

Review Comment:
   I confirmed that the TaskCompletionListener and TaskFailureListener classes themselves have been marked as `DeveloperApi` since ~2014/2015 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org