You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/11/06 16:03:18 UTC

Review Request 27653: SQOOP-1518:DOC: Update the Rest api.rst

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27653/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1518
    https://issues.apache.org/jira/browse/SQOOP-1518


Repository: sqoop-sqoop2


Description
-------

see JIRA for details 


Diffs
-----

  docs/src/site/sphinx/RESTAPI.rst 0117cb6 

Diff: https://reviews.apache.org/r/27653/diff/


Testing
-------


Thanks,

Veena Basavaraj

Re: Review Request 27653: SQOOP-1518:DOC: Update the Rest api.rst

Posted by Abraham Elmahrek <ab...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27653/#review60190
-----------------------------------------------------------

Ship it!


Good stuff.


docs/src/site/sphinx/RESTAPI.rst
<https://reviews.apache.org/r/27653/#comment101536>

    "is running the ``port``" => "is running, the ``port``"



docs/src/site/sphinx/RESTAPI.rst
<https://reviews.apache.org/r/27653/#comment101540>

    "the ``JSON`` format" => "``JSON`` format"



docs/src/site/sphinx/RESTAPI.rst
<https://reviews.apache.org/r/27653/#comment101543>

    Might help to have an example



docs/src/site/sphinx/RESTAPI.rst
<https://reviews.apache.org/r/27653/#comment101544>

    LinkConfiguration => ``LinkConfiguration``



docs/src/site/sphinx/RESTAPI.rst
<https://reviews.apache.org/r/27653/#comment101547>

    "The reading from" => "Reading from a data source"
    "the writing to" => "writing to a data source"
    
    For the above two, you could also do the following: "Reading from and writing to a data source are represented by ``From`` and ``To`` respectively."



docs/src/site/sphinx/RESTAPI.rst
<https://reviews.apache.org/r/27653/#comment101548>

    "in the API request" => "in an API request"



docs/src/site/sphinx/RESTAPI.rst
<https://reviews.apache.org/r/27653/#comment101549>

    a input => an input



docs/src/site/sphinx/RESTAPI.rst
<https://reviews.apache.org/r/27653/#comment101550>

    A error => An error



docs/src/site/sphinx/RESTAPI.rst
<https://reviews.apache.org/r/27653/#comment101552>

    REST APIs?



docs/src/site/sphinx/RESTAPI.rst
<https://reviews.apache.org/r/27653/#comment101555>

    space



docs/src/site/sphinx/RESTAPI.rst
<https://reviews.apache.org/r/27653/#comment101554>

    space


- Abraham Elmahrek


On Nov. 6, 2014, 3:03 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27653/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 3:03 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1518
>     https://issues.apache.org/jira/browse/SQOOP-1518
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA for details 
> 
> 
> Diffs
> -----
> 
>   docs/src/site/sphinx/RESTAPI.rst 0117cb6 
> 
> Diff: https://reviews.apache.org/r/27653/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>