You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/19 14:42:42 UTC

[GitHub] [beam] Abacn commented on a diff in pull request #24734: Terraform code for Self-Hosted Runners

Abacn commented on code in PR #24734:
URL: https://github.com/apache/beam/pull/24734#discussion_r1081363977


##########
.github/gh-actions-self-hosted-runners/README.md:
##########
@@ -21,29 +21,29 @@ The current GitHub Actions workflows are being tested on multiple operating syst
 On the other hand, we will rely on GitHub-hosted runners for MacOS builds until a straightforward implementation approach comes out.
 
 ## Ubuntu
-Ubuntu Self-hosted runners are stored in Artifact Registry and implemented using Google Kubernetes Engine with the following specifications:
+Ubuntu Self-hosted runners are stored in Container Registry and implemented using Google Kubernetes Engine with the following specifications:
 
 #### Cluster
 * Cluster: [gh-actions-linux-runners](https://console.cloud.google.com/kubernetes/clusters/details/us-central1-a/gh-actions-linux-runners/details?project=apache-beam-testing)
-* Image: [linux-github-actions-runner](https://console.cloud.google.com/artifacts/docker/apache-beam-testing/us-central1/beam-github-actions/linux-github-actions-runner?project=apache-beam-testing)
+* Image: [linux-github-actions-runner](https://console.cloud.google.com/gcr/images/apache-beam-testing/global/ubuntu-runners-self-hosted?project=apache-beam-testing)

Review Comment:
   just wondering is this change reflecting these containers are moving from artifact registry to container registry? per gcp documentation container registry is in maintenance mode and artifact registry supersedes it. There is some voice to migrate existing container workflows to artifact registry though not yet happened.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org